feat: Timeline view for company work map / projects#4286
Merged
Conversation
Signed-off-by: Marko Anastasov <marko@operately.com>
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
WorkMapTimeline.tsxfile is quite large and mixes layout, rendering, and date/scale utilities; consider extracting the pure date/column helpers (e.g.calculateRange,buildColumns,startOfWeek/endOfWeek, etc.) into a separate utility module and/or breaking out subcomponents to keep the main component easier to maintain. - All date formatting in the timeline is hard-coded to the
en-USlocale; if the rest of the app is localized, it would be better to use a shared locale setting or formatter helpers instead of inlinenew Intl.DateTimeFormat("en-US", ...)instances.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `WorkMapTimeline.tsx` file is quite large and mixes layout, rendering, and date/scale utilities; consider extracting the pure date/column helpers (e.g. `calculateRange`, `buildColumns`, `startOfWeek`/`endOfWeek`, etc.) into a separate utility module and/or breaking out subcomponents to keep the main component easier to maintain.
- All date formatting in the timeline is hard-coded to the `en-US` locale; if the rest of the app is localized, it would be better to use a shared locale setting or formatter helpers instead of inline `new Intl.DateTimeFormat("en-US", ...)` instances.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Marko Anastasov <marko@operately.com>
Signed-off-by: Marko Anastasov <marko@operately.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.