Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

kubernetes upstream: add rook operator #348

Merged
merged 1 commit into from
May 16, 2019

Conversation

leseb
Copy link
Contributor

@leseb leseb commented May 13, 2019

Create a new operator under community-operators for Rook the Storage
Orchestrator for Kubernetes. This is the upstream version.

The initial implementation expects the Ceph cluster to be part of the
same namespace as the operator.
It also has all Rook's capabilities when it comes to creating, managing
and upgrading a cluster. Simply edit the cluster CR to apply any changes
to your deployment.

Signed-off-by: Sébastien Han seb@redhat.com

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 13, 2019
@leseb leseb changed the title upstream: add rook operator kubernetes upstream: add rook operator May 13, 2019
@leseb leseb force-pushed the rook-upstream branch 2 times, most recently from a391d7f to c9b18da Compare May 13, 2019 16:20
@cvp-ops
Copy link
Collaborator

cvp-ops commented May 13, 2019

PR includes changes to only the [upstream-community-operators] directory. No pipeline will be launched.

1 similar comment
@cvp-ops
Copy link
Collaborator

cvp-ops commented May 13, 2019

PR includes changes to only the [upstream-community-operators] directory. No pipeline will be launched.

@cvp-ops
Copy link
Collaborator

cvp-ops commented May 13, 2019

PR includes changes to only the [upstream-community-operators] directory. No pipeline will be launched.

@leseb
Copy link
Contributor Author

leseb commented May 13, 2019

Current Total Score: 32%...

@leseb
Copy link
Contributor Author

leseb commented May 13, 2019

The logs are full of errors, yet the CI is green https://travis-ci.com/operator-framework/community-operators/builds/111611074 🤔

@SamiSousa
Copy link
Contributor

@leseb The scorecard passes since your operator is running. Our CI also prints out the operator logs as well, which is where you are seeing the errors like this: https://travis-ci.com/operator-framework/community-operators/builds/111611074#L419

@cvp-ops
Copy link
Collaborator

cvp-ops commented May 13, 2019

PR includes changes to only the [upstream-community-operators] directory. No pipeline will be launched.

@leseb
Copy link
Contributor Author

leseb commented May 13, 2019

@SamiSousa looks like the issues are solved, I don't understand "CVP/pr-sanity-check"'s error here, am I missing something obvious? Thanks!

@dmesser
Copy link
Collaborator

dmesser commented May 14, 2019

Looks good. Can you elaborate in the description a little more what the Operator does? E.g. that it stands up a Ceph cluster with StatefulSets and whether or not it supports upgrades of Ceph as well as advanced lifecycle features as claimed in the capability level ("Full Lifecycle").
Also, any requirements on the Kubernetes node (devices, network) would be good to know.

@leseb
Copy link
Contributor Author

leseb commented May 14, 2019

Note: I successfully deployed a cluster using the same Travis job (injected a minimal CR).

@cvp-ops
Copy link
Collaborator

cvp-ops commented May 14, 2019

PR includes changes to only the [upstream-community-operators] directory. No pipeline will be launched.

@cvp-ops
Copy link
Collaborator

cvp-ops commented May 14, 2019

PR includes changes to only the [upstream-community-operators] directory. No pipeline will be launched.

@leseb leseb force-pushed the rook-upstream branch 7 times, most recently from 186ece7 to ff20180 Compare May 15, 2019 15:14
Create a new operator under community-operators for Rook the Storage
Orchestrator for Kubernetes. This is the Kubernetes upstream version.

The initial implementation expects the Ceph cluster to be part of the
same namespace as the operator.
It also has all Rook's capabilities when it comes to creating, managing
and upgrading a cluster. Simply edit the cluster CR to apply any changes
to your deployment.

Signed-off-by: Sébastien Han <seb@redhat.com>
@dmesser
Copy link
Collaborator

dmesser commented May 16, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2019
@dmesser dmesser merged commit 99c0144 into operator-framework:master May 16, 2019
mmgaggle added a commit to mmgaggle/community-operators that referenced this pull request Jun 13, 2019
The rook-ceph operator already existed in the catalog for kubernetes by way of
PR operator-framework#348. This adds those same files to the catalog for okd/openshift. There is
precedent for both upstream and downstream operators:

* Strimzi / AMQ Streams
* Infinispan / JBOSS Data Grid
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants