-
Notifications
You must be signed in to change notification settings - Fork 551
Add rook-ceph upstream operator to okd/openshift #436
Add rook-ceph upstream operator to okd/openshift #436
Conversation
The rook-ceph operator already existed in the catalog for kubernetes by way of PR operator-framework#348. This adds those same files to the catalog for okd/openshift. There is precedent for both upstream and downstream operators: * Strimzi / AMQ Streams * Infinispan / JBOSS Data Grid
|
Hi @mmgaggle. Thanks for your PR. I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mmgaggle Is this still WIP? Let us know when you think this is good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmgaggle It appears this patch is missing OpenShift-specific customizations generated from the following Make build invoked with OpenShift specific parameter "CSV_PLATFORM=ocp": https://github.com/rook/rook/blob/master/cluster/olm/ceph/README.md#build-rooks-csv-file.
|
@mmgaggle: Important announcement: Flat operator directory structure is obsolete from 23-rd of October 2019, only nested directory structure will be accepted. You can use nested structure before this date also. |
|
We decided to hold off until we had robust CSI machinery, and while that's in a good place now, I've been terribly busy and haven't gotten around to updating this PR to the latest and greatest. |
|
@mmgaggle As you are busy I would suggest to close this PR and you can open new one once ready. |
The rook-ceph operator already existed in the catalog for kubernetes by way of
PR #348. This adds those same files to the catalog for okd/openshift. There is
precedent for both upstream and downstream operators:
Thanks submitting your Operator. Please check below list before you create your Pull Request.
New Submissions
Updates to existing Operators
replacesproperty?Your submission should not
upstream-community-operatorsandcommunity-operatorsat onceOperator Description must contain (in order)
Operator Metadata should contain
Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file a PR against this repo and explain your need
2 For more information see here