Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

Conversation

@mmgaggle
Copy link

The rook-ceph operator already existed in the catalog for kubernetes by way of
PR #348. This adds those same files to the catalog for okd/openshift. There is
precedent for both upstream and downstream operators:

  • Strimzi / AMQ Streams
  • Infinispan / JBOSS Data Grid

Thanks submitting your Operator. Please check below list before you create your Pull Request.

New Submissions

Updates to existing Operators

  • Is your new CSV pointing to the previous version with the replaces property?
  • Have you tested an update to your Operator when deployed via OLM?

Your submission should not

  • Modify more than one operator
  • Submit operators to both upstream-community-operators and community-operators at once
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file a PR against this repo and explain your need

2 For more information see here

The rook-ceph operator already existed in the catalog for kubernetes by way of
PR operator-framework#348. This adds those same files to the catalog for okd/openshift. There is
precedent for both upstream and downstream operators:

* Strimzi / AMQ Streams
* Infinispan / JBOSS Data Grid
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2019
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 13, 2019
@openshift-ci-robot
Copy link
Collaborator

Hi @mmgaggle. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 13, 2019
@dmesser
Copy link
Collaborator

dmesser commented Jun 18, 2019

@mmgaggle Is this still WIP? Let us know when you think this is good to go.

Copy link

@ron1 ron1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmgaggle It appears this patch is missing OpenShift-specific customizations generated from the following Make build invoked with OpenShift specific parameter "CSV_PLATFORM=ocp": https://github.com/rook/rook/blob/master/cluster/olm/ceph/README.md#build-rooks-csv-file.

@jozzi
Copy link
Contributor

jozzi commented Oct 21, 2019

@mmgaggle What is the state of this PR? Can you please respond to previous question by @ron1 ?

This PR is stalled for long period and will be closed soon if abandoned.

@J0zi
Copy link
Collaborator

J0zi commented Oct 21, 2019

@mmgaggle: Important announcement: Flat operator directory structure is obsolete from 23-rd of October 2019, only nested directory structure will be accepted. You can use nested structure before this date also.

@mmgaggle
Copy link
Author

We decided to hold off until we had robust CSI machinery, and while that's in a good place now, I've been terribly busy and haven't gotten around to updating this PR to the latest and greatest.

@jozzi
Copy link
Contributor

jozzi commented Oct 22, 2019

@mmgaggle As you are busy I would suggest to close this PR and you can open new one once ready.

@mmgaggle mmgaggle closed this Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants