Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

Add v0.32.0 ClusterServiceVersion #667

Merged
merged 2 commits into from Sep 30, 2019
Merged

Add v0.32.0 ClusterServiceVersion #667

merged 2 commits into from Sep 30, 2019

Conversation

madorn
Copy link
Member

@madorn madorn commented Sep 5, 2019

add 0.32.0 CSV for prometheus Operator to community-operators and upstream-community-operators.

@openshift-ci-robot openshift-ci-robot added kubernetes-operator An Operator targeting OperatorHub.io openshift-operator An Operator targeting OpenShift / OKD labels Sep 5, 2019
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 5, 2019
@lilic
Copy link
Member

lilic commented Sep 6, 2019

Thanks for this! Will have a look.

cc @brancz @s-urbaniak

@J0zi J0zi self-assigned this Sep 9, 2019
@J0zi J0zi moved this from To do to In progress in Community Operator Submissions Sep 9, 2019
@J0zi
Copy link
Collaborator

J0zi commented Sep 9, 2019

@madorn please request every platform separately, do not mix community-operators and upstream-community-operators. It should be in separate PR.

And also template bellow is required, please edit it and use for both your requests.

Thanks submitting your Operator. Please check below list before you create your Pull Request.

New Submissions

  • Have you selected the Project Community Operator Submissions in your PR on the right-hand menu bar?
  • Are you familiar with our contribution guidelines?
  • Have you packaged and deployed your Operator for Operator Framework?
  • Have you tested your Operator with all Custom Resource Definitions?
  • Have you tested your Operator in all supported installation modes?

Updates to existing Operators

  • Is your new CSV pointing to the previous version with the replaces property?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?

Your submission should not

  • Modify more than one operator
  • Submit operators to both upstream-community-operators and community-operators at once
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file a PR against this repo and explain your need

2 For more information see here

@madorn
Copy link
Member Author

madorn commented Sep 9, 2019

@J0zi upstream-community-operators changes have been removed from this PR.

@brancz
Copy link
Contributor

brancz commented Sep 10, 2019

Looks like there is one linting error, otherwise this looks good from my side.

@J0zi
Copy link
Collaborator

J0zi commented Sep 11, 2019

@madorn, please fix 3 topics:

  • see my last comment ^ and fill the form (show as raw, copy to your post and fill)
  • every crd has spec.version not defined
  • Please squash your commits, just one is needed

@madorn
Copy link
Member Author

madorn commented Sep 11, 2019

@J0zi

  • CRD use of spec.version is deprecated. Use of spec.versions should be acceptable here.

  • previous commit has been squashed.

New Submissions
X Have you selected the Project Community Operator Submissions in your PR on the right-hand menu bar?
X Are you familiar with our contribution guidelines?
X Have you packaged and deployed your Operator for Operator Framework?
X Have you tested your Operator with all Custom Resource Definitions?
X Have you tested your Operator in all supported installation modes?

Updates to existing Operators
X Is your new CSV pointing to the previous version with the replaces property?
X Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
X Have you tested an update to your Operator when deployed via OLM?

Your submission should not
X Modify more than one operator
X Submit operators to both upstream-community-operators and community-operators at once
X Modify any files outside the above mentioned folders
X Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)
X Description about the managed Application and where to find more information
X Features and capabilities of your Operator and how to use it
X Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain
X Human readable name and 1-liner description about your Operator
X Valid category name1
X One of the pre-defined capability levels
X Links to the maintainer, source code and documentation
X Example templates for all Custom Resource Definitions intended to be used
X A quadratic logo

@J0zi
Copy link
Collaborator

J0zi commented Sep 12, 2019

@madorn, try spec.versions in CRD, we will see if it helps.

@madorn
Copy link
Member Author

madorn commented Sep 12, 2019

@madorn, try spec.versions in CRD, we will see if it helps.

@J0zi spec.versions was in the original commit. is there any issue with this?

@madorn
Copy link
Member Author

madorn commented Sep 17, 2019

@J0zi bump - can you confirm this PR looks okay?

@J0zi J0zi removed the kubernetes-operator An Operator targeting OperatorHub.io label Sep 18, 2019
@aneeshkp
Copy link
Contributor

operator-courier is not validating spec.versions. I have raised an issue to get this fixed.
operator-framework/operator-courier#163

@s-urbaniak
Copy link

@madorn ping, any update on this one? cc @sichvoge

@madorn
Copy link
Member Author

madorn commented Sep 30, 2019

@aneeshkp @J0zi what is the status of this? we would like to get this merged asap as it currently resolves this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1735691

@s-urbaniak @lilic

@aneeshkp
Copy link
Contributor

@madorn The fix for this is still pending. Unfortunately I can't push this to quay since operator-courier push will call same validations and fail. operator-framework/operator-courier#165

@madorn
Copy link
Member Author

madorn commented Sep 30, 2019

@aneeshkp if we revert back to using the deprecated spec.version field, can we merge?

@aneeshkp
Copy link
Contributor

@madorn , Yes , for now that should work.

@madorn
Copy link
Member Author

madorn commented Sep 30, 2019

@aneeshkp Done.

@aneeshkp
Copy link
Contributor

@madorn, It is hitting another know issue.

@madorn
Copy link
Member Author

madorn commented Sep 30, 2019

@aneeshkp what do we need to do to resolve this issue and get the pr merged ASAP?

@aneeshkp
Copy link
Contributor

@madorn I can merge this.

@aneeshkp
Copy link
Contributor

@madorn I am going to quickly deploy this on my cluster and do a basic sanity check before merging.

@aneeshkp
Copy link
Contributor

@madorn , FYI , Clicking on "pod monitor" on the UI, throws 404 `` Error
404: Page Not Found
The server doesn't have a resource type PodMonitor. Try refreshing the page if it was recently added. ```

@aneeshkp aneeshkp merged commit 6c53cc0 into operator-framework:master Sep 30, 2019
Community Operator Submissions automation moved this from In progress to Done Sep 30, 2019
@aneeshkp aneeshkp moved this from Done to Done & Pushed to Quay in Community Operator Submissions Sep 30, 2019
@madorn
Copy link
Member Author

madorn commented Sep 30, 2019

@aneeshkp I wasn't able to replicate the UI issue you were seeing - but thanks for testing and merging.

@bennyturns
Copy link

Its working for me now, thanks!!!

@lilic
Copy link
Member

lilic commented Oct 1, 2019

Thanks @madorn!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
openshift-operator An Operator targeting OpenShift / OKD size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
No open projects
Community Operator Submissions
  
Done & Pushed to Quay
Development

Successfully merging this pull request may close these issues.

None yet

8 participants