feat: record desired state in Context #3082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Laprun <claprun@redhat.com>
csviri
reviewed
Dec 2, 2025
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| public <R> R getOrComputeDesiredStateFor( |
Collaborator
There was a problem hiding this comment.
IMO this should be addded under defaultManagedDependentResourceContext , logically relates to that.
Collaborator
Author
There was a problem hiding this comment.
This is used for non-managed dependent resources as well: it's used everywhere desired is used and this isn't part of the public API anyway. It's only public because it's used in different packages but otherwise it would have been a package-only method.
csviri
approved these changes
Dec 2, 2025
Collaborator
|
Not sure if the test coverage is good enough this way, but let it be up to you to judge. |
Signed-off-by: Chris Laprun <metacosm@gmail.com>
xstefank
approved these changes
Dec 2, 2025
Collaborator
Author
|
Hmm, looks like the expectation tests are flaky… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Laprun claprun@redhat.com