-
Notifications
You must be signed in to change notification settings - Fork 68
✨ Add Bundle-Agnostic Configuration Validation Using JSON Schema #2316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
✨ Add Bundle-Agnostic Configuration Validation Using JSON Schema #2316
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
c547c6d to
05d349b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2316 +/- ##
========================================
Coverage 74.42% 74.42%
========================================
Files 91 92 +1
Lines 7057 7233 +176
========================================
+ Hits 5252 5383 +131
- Misses 1393 1422 +29
- Partials 412 428 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a753a5c to
f15ea9f
Compare
f15ea9f to
e9352a6
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e9352a6 to
c2e887e
Compare
1f3451a to
65bd4ef
Compare
65bd4ef to
195d51d
Compare
d78bf4a to
920f78e
Compare
920f78e to
aaa71d0
Compare
748193b to
9f2c1c1
Compare
9f2c1c1 to
cfa5cfc
Compare
cfa5cfc to
65da55b
Compare
65da55b to
5a6165e
Compare
5a6165e to
acfa1b5
Compare
acfa1b5 to
452dc45
Compare
452dc45 to
8087c3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bundle configuration is now validated using JSONSchema. Configuration errors (typos, missing required fields, wrong types) are caught immediately with clear error messages instead of failing during installation. Assisted-by: Cursor
8087c3f to
b828f0b
Compare
Bundle configuration is now validated using JSON Schema before installation. Configuration errors (typos, missing required fields, type mismatches) are caught immediately with clear error messages instead of failing during deployment.
Motivation
https://issues.redhat.com/browse/OPRUN-4112
Design
Introduced
ConfigSchemaProviderinterface to abstract schema source from validation logic:Detailed flow:
Do I Need to Configure watchNamespace?
Examples
✅ Works: No config needed
✅ Works: With config
❌ Fails: Missing required field
❌ Fails: Typo in field name
❌ Fails: Wrong namespace