-
Notifications
You must be signed in to change notification settings - Fork 68
🐛 (fix): Change make generate to not delete vendor files #2320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 (fix): Change make generate to not delete vendor files #2320
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a make verify failure by preventing the deletion of vendored zz_generated.deepcopy.go files during code generation.
- Updates the
generatetarget in the Makefile to exclude vendor directories when cleaning up generated deepcopy files - Adds
-not -path "*/vendor/*"to the find command to preserve 69 vendored deepcopy files inhack/tools/test-profiling/vendor/ - Ensures
git diff --exit-codesucceeds duringmake verifyby not deleting files that cannot be regenerated
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2320 +/- ##
==========================================
- Coverage 74.25% 74.22% -0.03%
==========================================
Files 91 91
Lines 7054 7054
==========================================
- Hits 5238 5236 -2
- Misses 1402 1403 +1
- Partials 414 415 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c8526e9
into
operator-framework:main
Summary
Fix
make verifyfailure caused by deletion of vendoredzz_generated.deepcopy.gofiles.Root Cause
The
generatetarget in theMakefiledeletes allzz_generated.deepcopy.gofiles underapi,cmd,hack, andinternal.This unintentionally removes 69 vendored deepcopy files inside
hack/tools/test-profiling/vendor/, which cannot be regenerated bycontroller-gen.As a result,
git diff --exit-codefails duringmake verify.Fix
Update the
findcommand to exclude vendor directories when cleaning up generated deepcopy files:This ensures vendored deepcopy files are preserved while still cleaning and regenerating project code.
References