Skip to content

Conversation

@camilamacedo86
Copy link
Contributor

Summary

Fix make verify failure caused by deletion of vendored zz_generated.deepcopy.go files.

Root Cause

The generate target in the Makefile deletes all zz_generated.deepcopy.go files under api, cmd, hack, and internal.
This unintentionally removes 69 vendored deepcopy files inside hack/tools/test-profiling/vendor/, which cannot be regenerated by controller-gen.
As a result, git diff --exit-code fails during make verify.

Fix

Update the find command to exclude vendor directories when cleaning up generated deepcopy files:

@find api cmd hack internal -name "zz_generated.deepcopy.go" -not -path "*/vendor/*" -delete

This ensures vendored deepcopy files are preserved while still cleaning and regenerating project code.

References

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner November 11, 2025 09:16
Copilot AI review requested due to automatic review settings November 11, 2025 09:16
@openshift-ci openshift-ci bot requested a review from oceanc80 November 11, 2025 09:16
@netlify
Copy link

netlify bot commented Nov 11, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit aab6675
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6912fef31fc1030008b52062
😎 Deploy Preview https://deploy-preview-2320--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a make verify failure by preventing the deletion of vendored zz_generated.deepcopy.go files during code generation.

  • Updates the generate target in the Makefile to exclude vendor directories when cleaning up generated deepcopy files
  • Adds -not -path "*/vendor/*" to the find command to preserve 69 vendored deepcopy files in hack/tools/test-profiling/vendor/
  • Ensures git diff --exit-code succeeds during make verify by not deleting files that cannot be regenerated

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.22%. Comparing base (b634dac) to head (aab6675).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2320      +/-   ##
==========================================
- Coverage   74.25%   74.22%   -0.03%     
==========================================
  Files          91       91              
  Lines        7054     7054              
==========================================
- Hits         5238     5236       -2     
- Misses       1402     1403       +1     
- Partials      414      415       +1     
Flag Coverage Δ
e2e 45.85% <ø> (+0.01%) ⬆️
experimental-e2e 48.22% <ø> (-0.04%) ⬇️
unit 58.53% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci
Copy link

openshift-ci bot commented Nov 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 11, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit c8526e9 into operator-framework:main Nov 11, 2025
30 checks passed
@camilamacedo86 camilamacedo86 deleted the fix-downstream-sync branch November 11, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants