Skip to content

🐛 Fix support-bundle collection on e2e failure#2755

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
pedjak:worktree-fix-support-bundle
Jun 9, 2026
Merged

🐛 Fix support-bundle collection on e2e failure#2755
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
pedjak:worktree-fix-support-bundle

Conversation

@pedjak

@pedjak pedjak commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add test/e2e/support-bundle.yaml spec file with collectors for cluster diagnostics
  • Pass the spec file to the support-bundle CLI in the e2e workflow

Fixes the Error: no collectors specified to run error introduced in #2750.

Test plan

  • Verify e2e workflow collects support-bundle artifacts on failure

Copilot AI review requested due to automatic review settings June 9, 2026 12:50
@openshift-ci openshift-ci Bot requested review from dtfranz and grokspawn June 9, 2026 12:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix support-bundle collection during e2e workflow failures by introducing an explicit SupportBundle spec file and passing it to the support-bundle CLI, addressing the “no collectors specified to run” error introduced in #2750.

Changes:

  • Add test/e2e/support-bundle.yaml to explicitly define support-bundle collectors.
  • Update the e2e GitHub Actions workflow to pass the spec file to support-bundle during failure diagnostics.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
test/e2e/support-bundle.yaml Introduces a SupportBundle spec intended to define which diagnostics collectors run in CI.
.github/workflows/e2e.yaml Updates the failure-handling step to invoke support-bundle with the new spec file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/e2e/support-bundle.yaml Outdated
@netlify

netlify Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 7038fdc
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6a28491243ceba0009848071
😎 Deploy Preview https://deploy-preview-2755--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@rashmigottipati rashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2026
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.95%. Comparing base (b15d736) to head (7038fdc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2755      +/-   ##
==========================================
- Coverage   66.96%   66.95%   -0.02%     
==========================================
  Files         149      149              
  Lines       11341    11341              
==========================================
- Hits         7595     7593       -2     
- Misses       3190     3191       +1     
- Partials      556      557       +1     
Flag Coverage Δ
e2e 35.20% <ø> (+0.02%) ⬆️
experimental-e2e 52.55% <ø> (-0.05%) ⬇️
unit 52.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort

tmshort commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Jun 9, 2026
@pedjak pedjak force-pushed the worktree-fix-support-bundle branch from 71d4342 to e717fa6 Compare June 9, 2026 16:20
@pedjak pedjak requested a review from rashmigottipati June 9, 2026 16:22

@rashmigottipati rashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2026
Add test/e2e/support-bundle.yaml spec file with collectors for cluster
diagnostics and pass it to the support-bundle CLI in the e2e workflow.

Fixes the "no collectors specified to run" error introduced in operator-framework#2750.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 9, 2026 17:10
@pedjak pedjak force-pushed the worktree-fix-support-bundle branch from e717fa6 to 7038fdc Compare June 9, 2026 17:10
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

collectors:
- clusterResources: {}
- clusterInfo: {}
- logs: {}

@rashmigottipati rashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2026
@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 53b5ecf into operator-framework:main Jun 9, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants