🐛 Fix support-bundle collection on e2e failure#2755
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix support-bundle collection during e2e workflow failures by introducing an explicit SupportBundle spec file and passing it to the support-bundle CLI, addressing the “no collectors specified to run” error introduced in #2750.
Changes:
- Add
test/e2e/support-bundle.yamlto explicitly define support-bundle collectors. - Update the e2e GitHub Actions workflow to pass the spec file to
support-bundleduring failure diagnostics.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/e2e/support-bundle.yaml |
Introduces a SupportBundle spec intended to define which diagnostics collectors run in CI. |
.github/workflows/e2e.yaml |
Updates the failure-handling step to invoke support-bundle with the new spec file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2755 +/- ##
==========================================
- Coverage 66.96% 66.95% -0.02%
==========================================
Files 149 149
Lines 11341 11341
==========================================
- Hits 7595 7593 -2
- Misses 3190 3191 +1
- Partials 556 557 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/approve |
71d4342 to
e717fa6
Compare
Add test/e2e/support-bundle.yaml spec file with collectors for cluster diagnostics and pass it to the support-bundle CLI in the e2e workflow. Fixes the "no collectors specified to run" error introduced in operator-framework#2750. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
e717fa6 to
7038fdc
Compare
| collectors: | ||
| - clusterResources: {} | ||
| - clusterInfo: {} | ||
| - logs: {} |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rashmigottipati, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
53b5ecf
into
operator-framework:main
Summary
test/e2e/support-bundle.yamlspec file with collectors for cluster diagnosticssupport-bundleCLI in the e2e workflowFixes the
Error: no collectors specified to runerror introduced in #2750.Test plan