New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1758008: Manual approval strategy ignored for subsequent releases #1059
Bug 1758008: Manual approval strategy ignored for subsequent releases #1059
Conversation
For an subscription with manual approval, only the initial installplan respects the approval requires. Subsequent installplans ignore the fact the approval status is still false and install the operator regardless. This issue is due to catalog incorrectly transitions the installplan into install phase without checking for approval condition. Signed-off-by: Vu Dinh <vdinh@redhat.com>
@dinhxuanvu: This pull request references Bugzilla bug 1758008, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
PTAL |
@dinhxuanvu The fix looks good - can you write a test for this so we don't regress? |
@dinhxuanvu: This pull request references Bugzilla bug 1758008, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2 similar comments
@dinhxuanvu: This pull request references Bugzilla bug 1758008, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dinhxuanvu: This pull request references Bugzilla bug 1758008, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dinhxuanvu Can this be triggered with an e2e test similar to the ones testing the OperatorGroup serviceaccount scope? i.e. create a manual installplan that would fail because of scope, then give the operatorgroup enough permission to install it, and then see it install anyway (even though it's manual)? |
25232d4
to
3e698bb
Compare
Signed-off-by: Vu Dinh <vdinh@redhat.com>
3e698bb
to
8b81a70
Compare
Signed-off-by: Vu Dinh <vdinh@redhat.com>
709daa2
to
738cd76
Compare
/retest |
Test case included. @ecordell Ready for final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Test looks good - thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
@dinhxuanvu: All pull requests linked via external trackers have merged. Bugzilla bug 1758008 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
For an subscription with manual approval, only the initial installplan
respects the approval requires. Subsequent installplans ignore the
fact the approval status is still false and install the operator
regardless. This issue is due to catalog incorrectly transitions
the installplan into install phase without checking for approval
condition.
Signed-off-by: Vu Dinh vdinh@redhat.com
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs