Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.2] Bug 1774752: schedule catalogsource pods to linux nodes only #1145

Merged
merged 3 commits into from Feb 7, 2020
Merged

[release-4.2] Bug 1774752: schedule catalogsource pods to linux nodes only #1145

merged 3 commits into from Feb 7, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1132

/assign Denton24646

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 20, 2019
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 20, 2019
Merged
5 tasks
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1773661, which is invalid:

  • expected the bug to target the "4.2.z" release, but it targets "4.3.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.2] Bug 1773661: schedule catalogsource pods to linux nodes only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 20, 2019
@exdx exdx changed the title [release-4.2] Bug 1773661: schedule catalogsource pods to linux nodes only [release-4.2] Bug 1774752: schedule catalogsource pods to linux nodes only Nov 20, 2019
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1774752, which is invalid:

  • expected dependent Bugzilla bug 1773661 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.2] Bug 1774752: schedule catalogsource pods to linux nodes only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@exdx
Copy link
Member

exdx commented Nov 21, 2019

/retest

@njhale
Copy link
Member

njhale commented Nov 21, 2019

Thanks!

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2019
@exdx
Copy link
Member

exdx commented Dec 20, 2019

/bugzilla-refresh

@exdx
Copy link
Member

exdx commented Dec 20, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 20, 2019
@openshift-ci-robot
Copy link
Collaborator

@exdx: This pull request references Bugzilla bug 1774752, which is valid.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 20, 2019
@exdx
Copy link
Member

exdx commented Dec 21, 2019

/retest

2 similar comments
@njhale
Copy link
Member

njhale commented Dec 23, 2019

/retest

@ecordell
Copy link
Member

ecordell commented Jan 6, 2020

/retest

@spadgett
Copy link
Contributor

spadgett commented Jan 8, 2020

openshift/console#3885 should fix the console test failures

/retest

@spadgett
Copy link
Contributor

spadgett commented Jan 9, 2020

/retest

@exdx
Copy link
Member

exdx commented Jan 10, 2020

/test e2e-aws-console-olm

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@exdx
Copy link
Member

exdx commented Jan 23, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2020
@ashcrow ashcrow removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 6, 2020
@ashcrow
Copy link

ashcrow commented Feb 6, 2020 •
edited

This has been on not passing/on hold for a while. Removing cherry-pick-approved until the PR has been revisited.

@exdx
Copy link
Member

exdx commented Feb 6, 2020

PR was originally put on hold due to the licensing year issue, which has been resolved recently. Ready to merge again.

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2020
@exdx
Copy link
Member

exdx commented Feb 6, 2020

/test verify

@exdx
Copy link
Member

exdx commented Feb 6, 2020

/retest

@ashcrow ashcrow added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 6, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ashcrow
Copy link

ashcrow commented Feb 7, 2020

Interestingly enough the olm test in the log shows it passed, yet it doesn't look like it reported success back to GH.

/test e2e-aws-console-olm

@openshift-merge-robot openshift-merge-robot merged commit 79afb21 into operator-framework:release-4.2 Feb 7, 2020
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1774752 has been moved to the MODIFIED state.

In response to this:

[release-4.2] Bug 1774752: schedule catalogsource pods to linux nodes only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

2 similar comments
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1774752 has been moved to the MODIFIED state.

In response to this:

[release-4.2] Bug 1774752: schedule catalogsource pods to linux nodes only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1774752 has been moved to the MODIFIED state.

In response to this:

[release-4.2] Bug 1774752: schedule catalogsource pods to linux nodes only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@jpeeler jpeeler Awaiting requested review from jpeeler

Assignees

@njhale njhale

@exdx exdx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@openshift-cherrypick-robot @openshift-ci-robot @exdx @njhale @ecordell @spadgett @openshift-bot @ashcrow @sdodson @openshift-merge-robot