chorse(.gitlab-ci.yml): add in manual deploy of branch #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charltonaustin
force-pushed
the
add_in_manual_deploy_of_branch
branch
11 times, most recently
from
4b6c2bb
to
3424f87
Compare
ericavonb
reviewed
Sep 1, 2017
.gitlab-ci.yml
Outdated
|
|
||
| - docker_ci_build | ||
| - deploy_preview | ||
| - stop-preview |
There was a problem hiding this comment.
Can we be consistent with dashes vs underscores?
charltonaustin
force-pushed
the
add_in_manual_deploy_of_branch
branch
18 times, most recently
from
662fc0d
to
ffc46b0
Compare
charltonaustin
force-pushed
the
add_in_manual_deploy_of_branch
branch
2 times, most recently
from
6fef7e6
to
afa9e07
Compare
ecordell
reviewed
Sep 1, 2017
deploy/helm.Dockerfile
Outdated
| @@ -0,0 +1,16 @@ | |||
| FROM ubuntu:16.04 | |||
There was a problem hiding this comment.
quay.io/quay/alm-ci-build:latest I'll change the name
- [ ] It works! - [ ] Comments provide sufficient explanations for the next contributor - [ ] Tests cover changes and corner cases - [ ] Follows Quay syntax patterns and format
charltonaustin
force-pushed
the
add_in_manual_deploy_of_branch
branch
from
afa9e07
to
0aac519
Compare
jzelinskie
reviewed
Sep 1, 2017
| @@ -1,18 +1,22 @@ | |||
| image: golang:1.9.0 | |||
|
|
|||
| variables: | |||
| GIT_REPO_NAME: github.com/coreos-inc/alm | |||
| IMAGE_REPO_NAME: quay.io/quay/alm | |||
There was a problem hiding this comment.
why isn't this in the coreos/coreosinc namespace on quay?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Reviewer Checklist