-
Notifications
You must be signed in to change notification settings - Fork 567
Fix the version sub-command for the executables in this repository #2657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the version sub-command for the executables in this repository #2657
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
163bdb5 to
9601515
Compare
| release: ver=$(GIT_TAG) | ||
| release: manifests | ||
| @echo "Generating the $(ver) release" | ||
| docker pull $(IMAGE_REPO):$(ver) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an ordering issue here? Will this image exist without a tag in the remote repo? If we push a tag before we generate the release manifests, then they won't be present in the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be fine as we always override this ver variable during the release process, so the ordering problem shouldn't be an issue as we trigger the release process when a new git tag is created.
Side note: It felt like this target needs to be reworked but I didn't want to tackle any structuring changes in this PR.
9601515 to
55b70ab
Compare
55b70ab to
be2a3cc
Compare
This just popped up after merging the k8s 1.23 rebase. We ran into issues with this test before, so we should keep an eye out if e2e start failing consistently in the short term. |
be2a3cc to
06ba742
Compare
06ba742 to
3049a2b
Compare
3049a2b to
cdf60f4
Compare
This file is now out-of-date as we no longer use this file to track OLM release versioning. Signed-off-by: timflannagan <timflannagan@gmail.com>
Update the build and release related Makefile targets to consume the latest annotated git tag information. Signed-off-by: timflannagan <timflannagan@gmail.com>
cdf60f4 to
d5860c1
Compare
Description of the change:
Remove the out-of-date OLM_VERSION static file that was previously used in the release process before goreleaser was integrated in this repository. Update the Makefile and Dockerfile to get this information through git and populating the version fields at runtime.
Motivation for the change:
/cleanup
Sample output when run locally:
Reviewer Checklist
/doc[FLAKE]are truly flaky[FLAKE]tag are no longer flaky