Skip to content

Conversation

@anik120
Copy link
Contributor

@anik120 anik120 commented Oct 23, 2025

Description of the change:

Replace short image names (nginx:, bitnami/nginx:, repo/image:) with fully qualified names (docker.io/) in tests to resolve failures in OpenShift clusters with container image short name enforcement enabled.

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

Replace short image names (nginx:*, bitnami/nginx:*, repo/image:*) with
fully qualified names (docker.io/*) in tests to resolve failures in
OpenShift clusters with container image short name enforcement enabled.
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2025
@grokspawn
Copy link
Contributor

grokspawn commented Oct 23, 2025

I would prefer a title that was less downstream-y, like "fully-specify image pullspec source registries for compatibility with non-docker container environments".

@openshift-merge-bot openshift-merge-bot bot merged commit 465ea2e into operator-framework:master Oct 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants