Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate internal API client wrappers from generated external clients #432

Merged
merged 2 commits into from Aug 29, 2018

Conversation

ecordell
Copy link
Member

This moves our custom kube client interfaces out of api/client so that authors of software using OLM types can import just the types they want.

Also fixes cp to address #430

Copy link
Collaborator

@tkashem tkashem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecordell ecordell merged commit 5078357 into operator-framework:master Aug 29, 2018
njhale pushed a commit to njhale/operator-lifecycle-manager that referenced this pull request Sep 10, 2018
Separate internal API client wrappers from generated external clients
ecordell added a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
Separate internal API client wrappers from generated external clients
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants