Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1727032 Report Upgradeable in ClusterOperator status #971

Merged
merged 1 commit into from Aug 1, 2019
Merged

Bug 1727032 Report Upgradeable in ClusterOperator status #971

merged 1 commit into from Aug 1, 2019

Conversation

kevinrizza
Copy link
Member

Update status reporting for Openshift ClusterOperator status to report
the Upgradeable condition in the following context:

  • When upgrading (Progressing == true and Available == false) set
    Upgradeable to false
  • Once upgrade is complete, set Upgradeable to true

This PR resolves the following bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1727032
https://bugzilla.redhat.com/show_bug.cgi?id=1727042

@kevinrizza
Report Upgradeable in ClusterOperator status
4da8ef4 
Update status reporting for Openshift `ClusterOperator` status to report
the `Upgradeable` condition in the following context:
* When upgrading (`Progressing == true` and `Available == false`) set
`Upgradeable` to `false`
* Once upgrade is complete, set `Upgradeable` to `true`
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 30, 2019
@ecordell
Copy link
Member

/retest
/lgtm

long term, I think we want to be able to signal not-upgradeable based on the state of a set of installed operators

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2019
@kevinrizza
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit f674e44 into operator-framework:master Aug 1, 2019
@ecordell
Copy link
Member

ecordell commented Aug 7, 2019

/cherry-pick release-4.1

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 7, 2019
Merged
@openshift-cherrypick-robot
Copy link

@ecordell: new pull request created: #979

In response to this:

/cherry-pick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@njhale njhale Awaiting requested review from njhale

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kevinrizza @ecordell @openshift-ci-robot @openshift-cherrypick-robot @openshift-merge-robot