Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1727023: [status] Add upgradeable condition #215

Merged

Conversation

awgreene
Copy link
Member

@awgreene awgreene commented Jul 9, 2019

Problem: The Marketplace ClusterOperator currently does not report
the Upgradeable ClusterOperatorStatus condition.

Solution: Marketplace should always report the Upgradeable is true

@openshift-ci-robot
Copy link
Contributor

@awgreene: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1727023: Fix missing upgradeable condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 9, 2019
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 9, 2019
@awgreene
Copy link
Member Author

awgreene commented Jul 9, 2019

This should be merged after #214

@awgreene awgreene changed the title Bug 1727023: Fix missing upgradeable condition Bug 1727023: [status] Fix upgradeable condition Jul 9, 2019
@awgreene
Copy link
Member Author

awgreene commented Jul 9, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2019
pkg/status/status.go Outdated Show resolved Hide resolved
Copy link
Member

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[status] Fix upgradeable condition. Please make this [status] Add upgradeable condition.

@awgreene awgreene force-pushed the bug-1727023 branch 5 times, most recently from c61be3c to fc954b6 Compare July 12, 2019 19:20
@awgreene
Copy link
Member Author

@aravindhp @kevinrizza this PR is ready for review.

@awgreene awgreene changed the title Bug 1727023: [status] Fix upgradeable condition Bug 1727023: [status] Add upgradeable condition Jul 12, 2019
Copy link
Member

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2019
@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2019
Problem: The Marketplace ClusterOperator currently does not report
the Upgradeable ClusterOperatorStatus condition.

Solution: Marketplace can be upgraded at any point, and so should
always report Upgradeable as true.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2019
@awgreene
Copy link
Member Author

I had forgotten to update the e2e-test, addressed in the updated commit.

@awgreene
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2019
Copy link
Member

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@awgreene
Copy link
Member Author

/test e2e-aws-upgrade

@awgreene
Copy link
Member Author

/test e2e-aws-console-olm

@openshift-merge-robot openshift-merge-robot merged commit 336e11e into operator-framework:master Jul 15, 2019
@openshift-ci-robot
Copy link
Contributor

@awgreene: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state.

In response to this:

Bug 1727023: [status] Add upgradeable condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@awgreene: The Bugzilla bug is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Bug 1727023: [status] Add upgradeable condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants