New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1727023: [status] Add upgradeable condition #215
Bug 1727023: [status] Add upgradeable condition #215
Conversation
|
@awgreene: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This should be merged after #214 |
|
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[status] Fix upgradeable condition. Please make this [status] Add upgradeable condition.
c61be3c
to
fc954b6
Compare
|
@aravindhp @kevinrizza this PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
/lgtm |
Problem: The Marketplace ClusterOperator currently does not report the Upgradeable ClusterOperatorStatus condition. Solution: Marketplace can be upgraded at any point, and so should always report Upgradeable as true.
|
I had forgotten to update the e2e-test, addressed in the updated commit. |
|
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aravindhp, awgreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-upgrade |
|
/test e2e-aws-console-olm |
|
@awgreene: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@awgreene: The Bugzilla bug is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Problem: The Marketplace ClusterOperator currently does not report
the Upgradeable ClusterOperatorStatus condition.
Solution: Marketplace should always report the Upgradeable is true