Bug 1787660: Add CLI flag to set ClusterOperator name. #280
Conversation
openshift-ci-robot
added
the
size/XXL
benluddy
changed the title
|
@benluddy: This pull request references Bugzilla bug 1787660, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
If the flag is set to a non-empty string, and config.openshift.io/v1 isn't available, then the operator exits with an error status. Previously, the absence of configv1 would log a warning and continue running without ever updating ClusterOperator status. If this occurred during an OpenShift cluster upgrade, the upgrade would time out waiting for marketplace to report success via its ClusterOperator. Outside of an OpenShift cluster, the new flag can be omitted (or set to the empty string) to disable ClusterOperator status updates altogether.
benluddy
force-pushed
the
optional-cluster-operator-status
branch
from
974d82c
to
581f9b8
Compare
|
/retest |
There was a problem hiding this comment.
I'm not opposed to removing the /deploy folder in master, but I feel like we should do it in a separate pr when master is open. When we try to cherrypick this pr for a backport we don't necessarily want to include that change since it may still be used there -- it seems unrelated to the rest of the purpose of this pr anyway.
Aside from that and one or two nits, this looks good to me.
| @@ -4,7 +4,7 @@ import ( | |||
| "context" | |||
|
|
|||
| "github.com/operator-framework/operator-marketplace/pkg/apis/operators/shared" | |||
| "github.com/operator-framework/operator-marketplace/pkg/apis/operators/v1" | |||
| v1 "github.com/operator-framework/operator-marketplace/pkg/apis/operators/v1" | |||
There was a problem hiding this comment.
What's the point of this alias?
There was a problem hiding this comment.
That is weird. I have an after-save hook to tell gopls to organize imports, but I didn't notice that it had done that.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@benluddy: All pull requests linked via external trackers have merged. Bugzilla bug 1787660 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If the flag is set to a non-empty string, and config.openshift.io/v1
isn't available, then the operator exits with an error
status. Previously, the absence of configv1 would log a warning and
continue running without ever updating ClusterOperator status. If this
occurred during an OpenShift cluster upgrade, the upgrade would time
out waiting for marketplace to report success via its ClusterOperator.
Outside of an OpenShift cluster, the new flag can be omitted (or set
to the empty string) to disable ClusterOperator status updates
altogether.