New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1797801: Update the Hive and reporting-operator charts to work with single-stack ipv4 and ipv6. #1092
Bug 1797801: Update the Hive and reporting-operator charts to work with single-stack ipv4 and ipv6. #1092
Conversation
/retitle Bug 1797801: Update the Hive and reporting-operator charts to work with single-stack ipv4 and ipv6. |
@timflannagan1: This pull request references Bugzilla bug 1797801, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@timflannagan1: This pull request references Bugzilla bug 1797801, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This needs some updating |
19e64b7
to
76e60d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
/lgtm |
56a273c
to
2723b8a
Compare
/retest |
1 similar comment
/retest |
/retest |
1 similar comment
/retest |
Not entirely sure what's happening here. Both of the metering-ansible-operator Dockerfiles build locally fine, and the previous PR that added the |
2723b8a
to
35d0d42
Compare
/retest |
0a978d9
to
0c8bc30
Compare
…th single-stack ipv4 and ipv6. This is a follow-up to PR kube-reporting#1077 which introduced support for using S3 as the storage backend in a IPV6 cluster. The changes in this PR update the Hive ghostunnel configuration needed to support both a single-stack configuration, dependent on the value of the top-level .useIPV6Networking. In the case of the pkg/reporting-operator/cmd.go flags, we typically override the default values through the corresponding environment variable, which is reflected in the reporting-operator deployment changes. It's important to note that this means we need to be more careful when interacting with the CLI explicitly (i.e. in the case of running the reporting-operator locally, or in the e2e suite.)
0c8bc30
to
8cb021c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilyM1, timflannagan1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@timflannagan1: All pull requests linked via external trackers have merged. Bugzilla bug 1797801 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a follow-up to PR #1077 which introduced support for using S3 as the storage backend in an IPV6 cluster. The changes in this PR update the Hive ghostunnel configuration needed to support both a single-stack configuration, dependent on the value of the top-level .useIPV6Networking.
In the case of the pkg/reporting-operator/cmd.go flags, we typically override the default values through the corresponding environment variable, which is reflected in the reporting-operator deployment changes. It's important to note that this means we need to be more careful when interacting with the CLI explicitly (i.e. in the case of running the reporting-operator locally, or in the e2e suite.)