Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1797801: Update the Hive and reporting-operator charts to work with single-stack ipv4 and ipv6. #1092

Merged

Conversation

timflannagan
Copy link
Member

This is a follow-up to PR #1077 which introduced support for using S3 as the storage backend in an IPV6 cluster. The changes in this PR update the Hive ghostunnel configuration needed to support both a single-stack configuration, dependent on the value of the top-level .useIPV6Networking.

In the case of the pkg/reporting-operator/cmd.go flags, we typically override the default values through the corresponding environment variable, which is reflected in the reporting-operator deployment changes. It's important to note that this means we need to be more careful when interacting with the CLI explicitly (i.e. in the case of running the reporting-operator locally, or in the e2e suite.)

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 3, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2020
@timflannagan
Copy link
Member Author

/retitle Bug 1797801: Update the Hive and reporting-operator charts to work with single-stack ipv4 and ipv6.

@openshift-ci-robot openshift-ci-robot changed the title charts: Update the Hive and reporting-operator helm charts to work with single-stack ipv4 and ipv6. Bug 1797801: Update the Hive and reporting-operator charts to work with single-stack ipv4 and ipv6. Feb 3, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 3, 2020
@openshift-ci-robot
Copy link

@timflannagan1: This pull request references Bugzilla bug 1797801, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1797801: Update the Hive and reporting-operator charts to work with single-stack ipv4 and ipv6.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 3, 2020
@openshift-ci-robot
Copy link

@timflannagan1: This pull request references Bugzilla bug 1797801, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link
Member Author

This needs some updating
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2020
@timflannagan timflannagan force-pushed the tls-ipv6-changes branch 4 times, most recently from 19e64b7 to 76e60d5 Compare February 13, 2020 22:03
Copy link
Member

@EmilyM1 EmilyM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2020
@timflannagan
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Feb 13, 2020
@EmilyM1
Copy link
Member

EmilyM1 commented Feb 14, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2020
@timflannagan
Copy link
Member Author

/retest

1 similar comment
@timflannagan
Copy link
Member Author

/retest

@timflannagan
Copy link
Member Author

/retest

1 similar comment
@timflannagan
Copy link
Member Author

/retest

@timflannagan
Copy link
Member Author

Not entirely sure what's happening here. Both of the metering-ansible-operator Dockerfiles build locally fine, and the previous PR that added the botocore package also built fine. I'm going to nuke the namespace in CI and see if it resolves itself.
/retest

@timflannagan
Copy link
Member Author

/retest

@timflannagan timflannagan force-pushed the tls-ipv6-changes branch 3 times, most recently from 0a978d9 to 0c8bc30 Compare February 15, 2020 21:46
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 16, 2020
…th single-stack ipv4 and ipv6.

This is a follow-up to PR kube-reporting#1077 which introduced support for using S3 as the storage backend in a IPV6 cluster. The changes in this PR update the Hive ghostunnel configuration needed to support both a single-stack configuration, dependent on the value of the top-level .useIPV6Networking.

In the case of the pkg/reporting-operator/cmd.go flags, we typically override the default values through the corresponding environment variable, which is reflected in the reporting-operator deployment changes. It's important to note that this means we need to be more careful when interacting with the CLI explicitly (i.e. in the case of running the reporting-operator locally, or in the e2e suite.)
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 16, 2020
Copy link
Member

@EmilyM1 EmilyM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilyM1, timflannagan1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 27b0df8 into kube-reporting:master Feb 17, 2020
@openshift-ci-robot
Copy link

@timflannagan1: All pull requests linked via external trackers have merged. Bugzilla bug 1797801 has been moved to the MODIFIED state.

In response to this:

Bug 1797801: Update the Hive and reporting-operator charts to work with single-stack ipv4 and ipv6.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan timflannagan deleted the tls-ipv6-changes branch February 18, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants