Skip to content

bundle validation discrepancies between operator-registry and api projects #640

@jchunkins

Description

@jchunkins

I’ve noticed that there’s a discrepancy between the bundle validators in the api and operator registry projects.

Examining the commits in these files:
https://github.com/operator-framework/api/commits/master/pkg/validation/internal/bundle.go
https://github.com/operator-framework/operator-registry/commits/master/pkg/lib/validation/bundle.go

It appears that Vu removed the bundle validator from the api project and moved the code to operator registry around May 5-6th 2020, but then in an effort to remove cyclic dependencies Kevin re-added the bundle validation back into the api project (and made further modifications) on May 21 2020. The problem is, the operator registry project still has the older validator in place, and few changes have been made there whereas the api variant has been maintained over time.
From my point of view it appears that the variant in the operator registry should be removed and rely on the api variant for consistency. Of course I could be missing something important for why there’s two implementations, hence the question… should the registry code be changed to rely on the api variant?

Started to discuss this in slack at https://kubernetes.slack.com/archives/C0181L6JYQ2/p1618750466026500 and it was suggested that I open a ticket here.

Metadata

Metadata

Assignees

Labels

kind/featureCategorizes issue or PR as related to a new feature.lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.triagedIssue has been considered by a member of the OLM community

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions