Skip to content

(bug) fixing reliance on candidate channel containing all referenced bundles #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2022
Merged

(bug) fixing reliance on candidate channel containing all referenced bundles #1009

merged 1 commit into from
Aug 24, 2022

Conversation

@grokspawn
Copy link
Contributor

@grokspawn grokspawn commented Aug 3, 2022

Signed-off-by: Jordan Keister jordan@nimblewidget.com

Description of the change:
opm alpha render-veneer semver is dependent on the Candidates channel including all bundles to be referenced in channel/edge creation. Instead, we need to build a list of all referenced bundles and pre-render them.

Closes #1008

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot requested review from anik120 and awgreene August 3, 2022 19:26
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022 •
edited
Loading

Codecov Report

Merging #1009 (a0e8537) into master (166ed6b) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1009      +/-   ##
==========================================
- Coverage   52.97%   52.94%   -0.04%     
==========================================
  Files         105      105              
  Lines        9606     9612       +6     
==========================================
  Hits         5089     5089              
- Misses       3562     3568       +6     
  Partials      955      955
Impacted Files Coverage Δ
alpha/veneer/semver/semver.go 60.00% <0.00%> (-1.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@grokspawn grokspawn removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2022
@bentito
Copy link
Contributor

bentito commented Aug 23, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2022
@grokspawn grokspawn added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2022
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@grokspawn
fixing reliance on candidate channel containing all referenced bundles
a0e8537 
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022
@bentito
Copy link
Contributor

bentito commented Aug 24, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 52e35f0 into master Aug 24, 2022
@grokspawn grokspawn deleted the semver-lookup-fix branch August 24, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anik120 anik120 Awaiting requested review from anik120

@awgreene awgreene Awaiting requested review from awgreene

Assignees

@bentito bentito

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(bug) render-veneer semver relies on Candidate channel bundle list to be complete

5 participants

@grokspawn @bentito @openshift-bot @openshift-merge-robot