New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1840727: fix(unpack): support unpacking readonly folders #340
Conversation
layer unpacking preserves the original filemode. If the layer contains a readonly director, this would cause unpack to fail, because the dir on disk would not be writeable, and it's children would fail to write. this change makes all unpacked files owner-writable, which has some implications for how unpacked files should be used, but for purposes within opm this will not be an issue.
@ecordell: This pull request references Bugzilla bug 1840727, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@ecordell: This pull request references Bugzilla bug 1840727, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, gallettilance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@ecordell: All pull requests linked via external trackers have merged: operator-framework/operator-registry#340. Bugzilla bug 1840727 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of the change:
this change makes all unpacked files owner-writable, which has some
implications for how unpacked files should be used, but for purposes
within opm this will not be an issue.
Motivation for the change:
layer unpacking preserves the original filemode. If the layer contains
a readonly director, this would cause unpack to fail, because the dir
on disk would not be writeable, and it's children would fail to write.
Reviewer Checklist
/docs