New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1904297: Unexpected images left in related_images
after pruning
#556
Bug 1904297: Unexpected images left in related_images
after pruning
#556
Conversation
the only exception is if the db is opened in read-only mode
pruning is often done right before mirroring, and leaving stranded bundles can lead to unexpected images in the image list.
@ecordell: This pull request references Bugzilla bug 1904297, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #556 +/- ##
==========================================
+ Coverage 49.45% 49.49% +0.03%
==========================================
Files 90 91 +1
Lines 6317 6302 -15
==========================================
- Hits 3124 3119 -5
+ Misses 2497 2492 -5
+ Partials 696 691 -5
Continue to review full report at Codecov.
|
/retest |
/lgtm |
/test e2e-aws |
@ecordell: This pull request references Bugzilla bug 1904297, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@ecordell: All pull requests linked via external trackers have merged: Bugzilla bug 1904297 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.6 |
@kevinrizza: new pull request created: #560 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label qe-approved |
@kevinrizza: new pull request could not be created: failed to create pull request against operator-framework/operator-registry#openshift-cherrypick-robot:cherry-pick-556-to-release-4.6 from release-4.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-556-to-release-4.6."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of the change:
Removes stranded bundles (bundles that are not referenced by any channel entry) after a prune operation.
This also abstracts database opening via a package that ensures foreign keys are always enabled - this bug was harder to fix because of this (even querying the db to check if foreign keys are enabled will lie to you if the db is not opened with that flag).
Motivation for the change:
Pruning is often done right before mirroring. If dangling bundles are not removed on prune, it can lead to unexpected images being mirrored.
It looks like this fixes #542
Reviewer Checklist
/docs