From 075868899cf622bcd65a8b6caeebd658cf3ac1b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Karel=20=C5=A0imon?= Date: Tue, 13 Aug 2019 15:26:15 +0200 Subject: [PATCH] k8s_status module: fix append issue, when condition was on 0 index when old condition is on index 0, new condition with same type was always appended, instead of replaced. --- internal/pkg/scaffold/ansible/k8s_status.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/internal/pkg/scaffold/ansible/k8s_status.go b/internal/pkg/scaffold/ansible/k8s_status.go index 2c9c5b02780..32706ccc4fb 100644 --- a/internal/pkg/scaffold/ansible/k8s_status.go +++ b/internal/pkg/scaffold/ansible/k8s_status.go @@ -367,7 +367,7 @@ class KubernetesAnsibleStatusModule(KubernetesAnsibleModule): for condition in new_conditions: idx = self.get_condition_idx(merged, condition['type']) - if idx: + if idx is not None: merged[idx] = condition else: merged.append(condition) @@ -378,6 +378,7 @@ class KubernetesAnsibleStatusModule(KubernetesAnsibleModule): for i, condition in enumerate(conditions): if condition.get('type') == name: return i + return None def object_contains(self, obj, subset): def dict_is_subset(obj, subset):