Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove k8s_status module, install from galaxy #2310

Merged
merged 2 commits into from Dec 12, 2019

Conversation

@asmacdo
Copy link
Member

asmacdo commented Dec 10, 2019

No description provided.

CHANGELOG.md Outdated Show resolved Hide resolved
@asmacdo asmacdo force-pushed the asmacdo:610-use-ansible-collection branch 2 times, most recently from 097da81 to dab5a87 Dec 11, 2019
@estroz
estroz approved these changes Dec 11, 2019
Copy link
Member

estroz left a comment

/lgtm

doc/ansible/dev/developer_guide.md Outdated Show resolved Hide resolved
doc/ansible/dev/developer_guide.md Outdated Show resolved Hide resolved
Copy link
Contributor

camilamacedo86 left a comment

Just the @estroz nits
And then, /lgtm /approved for me as well 🥇

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Dec 12, 2019

New changes are detected. LGTM label has been removed.

@asmacdo asmacdo force-pushed the asmacdo:610-use-ansible-collection branch from fad0802 to 3eb0c27 Dec 12, 2019
asmacdo and others added 2 commits Dec 9, 2019
Co-Authored-By: Eric Stroczynski <estroczy@redhat.com>
@asmacdo asmacdo force-pushed the asmacdo:610-use-ansible-collection branch from 3eb0c27 to f1d15fb Dec 12, 2019
Copy link
Contributor

joelanford left a comment

LGTM, after addressing my one nit/question.

collections:
- operator_sdk.util`
Comment on lines +101 to +102

This comment has been minimized.

Copy link
@joelanford

joelanford Dec 12, 2019

Contributor

Is there a best practice between declaring the collection like this and then using the shortened name in tasks vs using the fully qualified name in tasks?

This comment has been minimized.

@asmacdo asmacdo merged commit 8adf8db into operator-framework:master Dec 12, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 49.292%
Details
@asmacdo asmacdo deleted the asmacdo:610-use-ansible-collection branch Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.