From 51c79e614d44e1b5dafa4db62f501fc9709b0207 Mon Sep 17 00:00:00 2001 From: Eric Stroczynski Date: Thu, 29 Apr 2021 16:52:52 -0700 Subject: [PATCH] internal/cmd: format log.Info messages correctly Signed-off-by: Eric Stroczynski --- changelog/fragments/fmt-info-logs.yaml | 4 ++++ internal/cmd/ansible-operator/run/cmd.go | 2 +- internal/cmd/helm-operator/run/cmd.go | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 changelog/fragments/fmt-info-logs.yaml diff --git a/changelog/fragments/fmt-info-logs.yaml b/changelog/fragments/fmt-info-logs.yaml new file mode 100644 index 00000000000..298593f0063 --- /dev/null +++ b/changelog/fragments/fmt-info-logs.yaml @@ -0,0 +1,4 @@ +entries: + - description: > + Format ansible-operator and helm-operator `run` command logs correctly. + kind: bugfix diff --git a/internal/cmd/ansible-operator/run/cmd.go b/internal/cmd/ansible-operator/run/cmd.go index 88ca079cecf..dad2c9fefea 100644 --- a/internal/cmd/ansible-operator/run/cmd.go +++ b/internal/cmd/ansible-operator/run/cmd.go @@ -139,7 +139,7 @@ func run(cmd *cobra.Command, f *flags.Flags) { namespace, found := os.LookupEnv(k8sutil.WatchNamespaceEnvVar) log = log.WithValues("Namespace", namespace) if found { - log.V(1).Info("Setting namespace with value in %s", k8sutil.WatchNamespaceEnvVar) + log.V(1).Info(fmt.Sprintf("Setting namespace with value in %s", k8sutil.WatchNamespaceEnvVar)) if namespace == metav1.NamespaceAll { log.Info("Watching all namespaces.") options.Namespace = metav1.NamespaceAll diff --git a/internal/cmd/helm-operator/run/cmd.go b/internal/cmd/helm-operator/run/cmd.go index 198313bf306..3eecfd48898 100644 --- a/internal/cmd/helm-operator/run/cmd.go +++ b/internal/cmd/helm-operator/run/cmd.go @@ -135,7 +135,7 @@ func run(cmd *cobra.Command, f *flags.Flags) { namespace, found := os.LookupEnv(k8sutil.WatchNamespaceEnvVar) log = log.WithValues("Namespace", namespace) if found { - log.V(1).Info("Setting namespace with value in %s", k8sutil.WatchNamespaceEnvVar) + log.V(1).Info(fmt.Sprintf("Setting namespace with value in %s", k8sutil.WatchNamespaceEnvVar)) if namespace == metav1.NamespaceAll { log.Info("Watching all namespaces.") options.Namespace = metav1.NamespaceAll