Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize devito application #558

Merged
merged 1 commit into from May 2, 2018

Conversation

Projects
None yet
5 participants
@c-w
Copy link
Contributor

commented May 1, 2018

Paired with @navjotk

@codecov-io

This comment has been minimized.

Copy link

commented May 1, 2018

Codecov Report

Merging #558 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #558   +/-   ##
=======================================
  Coverage   75.82%   75.82%           
=======================================
  Files          74       74           
  Lines        7021     7021           
  Branches     1427     1427           
=======================================
  Hits         5324     5324           
  Misses       1524     1524           
  Partials      173      173

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d93c002...099aa77. Read the comment docs.

@FabioLuporini
Copy link
Contributor

left a comment

Thanks for this.

I'll ask for some beta-testing on Slack

README.md Outdated
git clone https://github.com/opesci/devito.git
cd devito
conda env create -f environment.yml

This comment has been minimized.

Copy link
@FabioLuporini

FabioLuporini May 1, 2018

Contributor

I think both options should stay. Conda, in particular, should be the way to go for developers.

This comment has been minimized.

Copy link
@mloubout

mloubout May 1, 2018

Contributor

Would keep conda too.

This comment has been minimized.

Copy link
@FabioLuporini

FabioLuporini May 1, 2018

Contributor

Also, the introductory paragraph above only talks about conda

This comment has been minimized.

Copy link
@c-w

c-w May 1, 2018

Author Contributor

Sounds good. I've restored the previous README state.

README.md Outdated
pip install -e .
# run tests
docker-compose run devito /tests

This comment has been minimized.

Copy link
@FabioLuporini

FabioLuporini May 1, 2018

Contributor

this assumes the presence of docker

This comment has been minimized.

Copy link
@c-w

c-w May 1, 2018

Author Contributor

Added a link to the Docker documentation.

@mloubout
Copy link
Contributor

left a comment

Fine overall.
I still would prefer it to be added as an second option and keep the previous README as this one makes it look like Devito can only be run through Docker.

@FabioLuporini
Copy link
Contributor

left a comment

OK, I'm happy now. I'd like to wait a bit for some feedback from any of our own users/developers to double check that this works as expected.

@FabioLuporini

This comment has been minimized.

Copy link
Contributor

commented May 2, 2018

People are confirming that this does work as expected. @navjotk @mloubout @ggorman any other comments?

@navjotk

This comment has been minimized.

Copy link
Member

commented May 2, 2018

I like it. Waiting for @mloubout to update his review.

@FabioLuporini

This comment has been minimized.

Copy link
Contributor

commented May 2, 2018

Cool, merging.

@FabioLuporini FabioLuporini merged commit 9a7fc91 into opesci:master May 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@FabioLuporini

This comment has been minimized.

Copy link
Contributor

commented May 2, 2018

Merged.

@c-w c-w deleted the c-w:dockerize branch May 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.