Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Performance Tweaks (#13)
* move code files to src

* Tweaks to make performance comparable to the standard library

* I succeeded in making my thing perform well!! + other tweaks
  • Loading branch information
opethe1st committed Aug 31, 2019
1 parent 943435f commit 7dd0b3c
Show file tree
Hide file tree
Showing 17 changed files with 518 additions and 334 deletions.
1 change: 1 addition & 0 deletions .gitignore
@@ -1 +1,2 @@
.vscode/
.DS_Store
18 changes: 0 additions & 18 deletions iterator.go

This file was deleted.

268 changes: 0 additions & 268 deletions load.go

This file was deleted.

6 changes: 6 additions & 0 deletions log.md
Expand Up @@ -42,3 +42,9 @@ Know when to break the rules!

Probably need to make sure this handles unicode

So just found out my implementation is horribly slow for this input compared to the standard libraries implementation. I wonder why that is the
case.


So I looked at the official go package and I can't see any reason why mine should be significantly slower. I initially thought it could be that I used
recursion but they used recursion too. I am trying out benchmarkig to figure this out.
8 changes: 4 additions & 4 deletions readme.md
Expand Up @@ -5,11 +5,11 @@ I wrote this to practise Go.

What's left?
* Handle whitespace ✅
* Error handling
* Handle boolean and null literals ✅
* Handle number literals ✅
* Handle string escapes ✅
* Write the dump function - > (easy? how do we know the type of the object being pointed to?)
* Benchmark against the standard libraries implementation
* Study the standard libraries implementation
* Benchmark against the standard libraries implementation ✅
* Study the standard libraries implementation
* Error handling
* Write about how I implemented the JSON spec in Go. Focus on what was difficult and what I learned.
* Write the dump function - > (easy? how do we know the type of the object being pointed to?)

0 comments on commit 7dd0b3c

Please sign in to comment.