Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace settings modals with tabbed portal table configuration modal #6245

Merged
merged 27 commits into from Apr 13, 2018

Conversation

@oliverguenther
Copy link
Member

@oliverguenther oliverguenther commented Mar 29, 2018

Uses a CDK portal to replace the modal services from angular-modal with a single , extendible TableConfiguration modal.

  • Provides a reusable TabPortalOutlet to switch between and instrument n tab components
  • Converts columns, sort-by, group-by, hierarchy and timeline modals

TODOS

  • Convert filter directive
@oliverguenther oliverguenther force-pushed the houskeeping/consolidated-ng2-modals branch from 6709c16 to 1701750 Apr 5, 2018
@oliverguenther oliverguenther changed the title Upgrade angular-modal to CDK portal modal service Replace settings modals with tabbed portal table configuration modal Apr 9, 2018
@oliverguenther oliverguenther force-pushed the houskeeping/consolidated-ng2-modals branch from 709863d to cf80ddc Apr 10, 2018
Remove when ng1 tests no longer use this directive.
…ed-ng2-modals
…ed-ng2-modals
@oliverguenther oliverguenther requested a review from ulferts Apr 12, 2018
[ci skip]
…ed-ng2-modals
@ulferts ulferts merged commit d523e51 into dev Apr 13, 2018
2 checks passed
2 checks passed
codeclimate 57 fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ulferts ulferts deleted the houskeeping/consolidated-ng2-modals branch Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants