Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace webpack-based build with Angular CLI + AOT #6346

Merged
merged 177 commits into from Jun 21, 2018
Merged

Replace webpack-based build with Angular CLI + AOT #6346

merged 177 commits into from Jun 21, 2018

Conversation

@oliverguenther
Copy link
Member

@oliverguenther oliverguenther commented May 28, 2018

TODOS

zone.js:192 Uncaught Error: No NgModule metadata found for 'AppModule'.
    at NgModuleResolver.push../node_modules/@angular/compiler/fesm5/compiler.js.NgModuleResolver.resolve (compiler.js:11795)
    at CompileMetadataResolver.push../node_modules/@angular/compiler/fesm5/compiler.js.CompileMetadataResolver.getNgModuleMetadata (compiler.js:10432)
    at JitCompiler.push../node_modules/@angular/compiler/fesm5/compiler.js.JitCompiler._loadModules (compiler.js:22570)
    at JitCompiler.push../node_modules/@angular/compiler/fesm5/compiler.js.JitCompiler._compileModuleAndComponents (compiler.js:22551)
    at JitCompiler.push../node_modules/@angular/compiler/fesm5/compiler.js.JitCompiler.compileModuleAsync (compiler.js:22511)
    at CompilerImpl.push../node_modules/@angular/platform-browser-dynamic/fesm5/platform-browser-dynamic.js.CompilerImpl.compileModuleAsync (platform-browser-dynamic.js:143)
    at PlatformRef.push../node_modules/@angular/core/fesm5/core.js.PlatformRef.bootstrapModule (core.js:4799)
    at HTMLDocument.<anonymous> (bootstrap.ts:27)
    at mightThrow (jquery.js:3534)
    at process (jquery.js:3602)

Also fixes / implements the following:

#27777
#27829

[ci skip]
Otherwise we can't use things like OpDatePicker from feature modules
…ields-implementation
@oliverguenther oliverguenther mentioned this pull request May 30, 2018
25 of 26 tasks complete
.search({ work_package_id: this.resource.id })
.toString();
this.projectCacheService
.require(this.resource.project.idFromLink)
@oliverguenther oliverguenther force-pushed the angular-cli branch from d161bf4 to e016d57 May 31, 2018
Also removes some code that is no longer loaded
oliverguenther and others added 25 commits Jun 20, 2018
It is needed in some components.
This would otherwise break on packager because bundle is not ready there
This removes the unchanged assertion test because that doesn't work
properly in TS 2.7
@oliverguenther oliverguenther merged commit c60eb93 into dev Jun 21, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
codeclimate Code Climate is analyzing this code.
Details
@oliverguenther oliverguenther deleted the angular-cli branch Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.