[#8] 클라이언트 설정과 네트워크 프로토콜을 구현한다#15
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
이번 PR은 Nexa 라이브러리의 핵심 설정인 NXClientConfiguration과 네트워크 통신을 위한 NXHTTPTransport 등의 프로토콜 및 기본 구현체를 추가합니다. 리뷰 결과, NXClientConfiguration 내 JSONDecoder와 JSONEncoder의 Sendable 준수 여부 확인 및 불변성 확보를 위한 let 선언 권장 사항이 있었으며, NXURLSessionTransport에서 불필요한 @unchecked Sendable을 제거하여 컴파일러의 안전성 검사를 활용하도록 하는 개선 제안이 포함되었습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
📝 작업 내용
📌 요약
NXClientConfigurationProtocolTests) 추가🔍 상세
NXHTTPTransportNXAuthTokenProviderNXServerErrorDecoderNXDefaultServerErrorDecoderNXURLSessionTransport추가NXClientConfiguration추가baseURL,headers,transport,decoder,encoder,serverErrorDecoder,authTokenProvider구성NXClientConfigurationProtocolTests추가swift test통과📸 영상 / 이미지 (Optional)