Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any further plans for improvement? #5

Closed
Rainer-Lang opened this issue Jun 29, 2015 · 6 comments
Closed

Any further plans for improvement? #5

Rainer-Lang opened this issue Jun 29, 2015 · 6 comments
Assignees

Comments

@Rainer-Lang
Copy link

Rainer-Lang commented Jun 29, 2015

Maybe RxJava... https://github.com/pwittchen/prefser

@vashisthg
Copy link
Contributor

Thanks for the suggestion. Wait for next iteration.

@vashisthg vashisthg added this to the v.02 milestone Jun 29, 2015
@Rainer-Lang
Copy link
Author

OK thanks for the fast answer.
When do you want to release .02?

@vashisthg
Copy link
Contributor

Let us discuss first about the usage of RxJava in our library and whether its an overkill for this project or not.
@Rainer-Lang What are your suggestions for where RxJava could be useful here.

cc @ragdroid

@vashisthg
Copy link
Contributor

As https://github.com/pwittchen/prefser wraps SharedPreferences, it could be used along with our library, So I don't think we need to reinvent the wheel. @vickyturtle @ragdroid What are your thoughts?

@ragdroid
Copy link
Contributor

@vashisthg Yes I agree.
Also I am not sure where RxJava can be applied. Maybe @vickyturtle can give us a better idea regarding this.

@vashisthg vashisthg removed this from the v.02 milestone Jun 29, 2015
@vickyturtle
Copy link

@vashisthg I don't think implementing RxJava in here makes much sense, but may be we can try to make secure-preferences injectable in https://github.com/pwittchen/prefser in place of normal SharedPreferences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants