IE 8+ #53

Closed
MicheleBertoli opened this Issue Aug 7, 2012 · 8 comments

Comments

Projects
None yet
4 participants

To make the library work on IE 8+ I had to modify the code at line 201 in this way:

        if (document.addEventListener) {
            document.addEventListener("DOMContentLoaded", callOnce, false);
        } else {
            callOnce();
        }

        // A fallback to window.onload, that will always work
        if (window.addEventListener) {
            window.addEventListener("load", callOnce);
        } else {
            callOnce();
        }

Otherwise, I got the following error:

Error: Object doesn't support property or method 'addEventListener'

Contributor

tbosch commented Aug 7, 2012

Hi,
did you test on IE9? addEventListener should work there... And Windows Phone Mange contains an IE9...

Tobias

On IE9 the library works without problems.
Thanks for the answer,
Michele

Contributor

tbosch commented Sep 3, 2012

Closing this as we will not support IE8 in the future.

@tbosch tbosch closed this Sep 3, 2012

Contributor

jperl commented Mar 10, 2013

Unfortunately IE8 share is still > 5% and I have to support it :( Will you accept pull requests for IE8 fixes?

What's the point of doing ie8 fixes when windows mobile handsets have ie9+?

Contributor

jperl commented Mar 10, 2013

If you are targeting web and mobile.
On Mar 10, 2013 6:21 PM, "rambocoder" notifications@github.com wrote:

What's the point of doing ie8 fixes when windows mobile handsets have ie9+?


Reply to this email directly or view it on GitHubhttps://github.com/tigbro/jquery-mobile-angular-adapter/issues/53#issuecomment-14690718
.

Contributor

tbosch commented Mar 11, 2013

Hello jperl,
would be awesome if you could provide a pull request for this! I will reopen this issue for you.

Tobias

@tbosch tbosch reopened this Mar 11, 2013

Contributor

jperl commented Mar 14, 2013

Sounds good. That project is coming up in about 2 weeks, so it will be a little time before then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment