Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

IE 8+ #53

Open
MicheleBertoli opened this Issue · 8 comments

4 participants

@MicheleBertoli

To make the library work on IE 8+ I had to modify the code at line 201 in this way:

        if (document.addEventListener) {
            document.addEventListener("DOMContentLoaded", callOnce, false);
        } else {
            callOnce();
        }

        // A fallback to window.onload, that will always work
        if (window.addEventListener) {
            window.addEventListener("load", callOnce);
        } else {
            callOnce();
        }

Otherwise, I got the following error:

Error: Object doesn't support property or method 'addEventListener'

@tbosch

Hi,
did you test on IE9? addEventListener should work there... And Windows Phone Mange contains an IE9...

Tobias

@MicheleBertoli

On IE9 the library works without problems.
Thanks for the answer,
Michele

@tbosch

Closing this as we will not support IE8 in the future.

@tbosch tbosch closed this
@jperl

Unfortunately IE8 share is still > 5% and I have to support it :( Will you accept pull requests for IE8 fixes?

@rambocoder

What's the point of doing ie8 fixes when windows mobile handsets have ie9+?

@jperl
@tbosch

Hello jperl,
would be awesome if you could provide a pull request for this! I will reopen this issue for you.

Tobias

@tbosch tbosch reopened this
@jperl

Sounds good. That project is coming up in about 2 weeks, so it will be a little time before then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.