diff --git a/src/opnsense/mvc/app/models/OPNsense/Base/Menu/Menu.xml b/src/opnsense/mvc/app/models/OPNsense/Base/Menu/Menu.xml index 78d0873828a..f01ac05a446 100644 --- a/src/opnsense/mvc/app/models/OPNsense/Base/Menu/Menu.xml +++ b/src/opnsense/mvc/app/models/OPNsense/Base/Menu/Menu.xml @@ -141,22 +141,10 @@ - - - - - - - - - - - - - - - - + + + + diff --git a/src/www/firewall_aliases.php b/src/www/firewall_aliases.php index f056bc2d883..298a49b9346 100644 --- a/src/www/firewall_aliases.php +++ b/src/www/firewall_aliases.php @@ -31,6 +31,25 @@ require_once("guiconfig.inc"); require_once("filter.inc"); +function find_alias_type($type) +{ + $types = array( + 'host' => gettext('Host(s)'), + 'network' => gettext('Network(s)'), + 'port' => gettext('Port(s)'), + 'url' => gettext('URL (IPs)'), + 'url_ports' => gettext('URL (Ports)'), + 'urltable' => gettext('URL Table (IPs)'), + 'urltable_ports' => gettext('URL Table (Ports)'), + ); + + if (isset($types[$type])) { + return $types[$type]; + } + + return $type; +} + function find_alias_reference($section, $field, $origname, &$is_alias_referenced, &$referenced_by) { global $config; if(!$origname || $is_alias_referenced) @@ -75,9 +94,6 @@ function find_alias_reference($section, $field, $origname, &$is_alias_referenced } $a_aliases = &$config['aliases']['alias']; -// determine selected tab -$selected_tab = htmlspecialchars(($_REQUEST['tab'] == "" ? "ip" : preg_replace("/\W/","",$_REQUEST['tab']))); - if ($_SERVER['REQUEST_METHOD'] === 'POST') { if (isset($_POST['apply'])) { /* reload all components that use aliases */ @@ -128,7 +144,7 @@ function find_alias_reference($section, $field, $origname, &$is_alias_referenced filter_configure(); mark_subsystem_dirty('aliases'); } - header("Location: firewall_aliases.php?tab=" . $selected_tab); + header('Location: firewall_aliases.php'); exit; } } @@ -137,7 +153,7 @@ function find_alias_reference($section, $field, $origname, &$is_alias_referenced legacy_html_escape_form_data($a_aliases); $main_buttons = array( - array('href'=>'firewall_aliases_edit.php?tab='.$selected_tab, 'label'=>gettext("Add a new alias")), + array('href' => 'firewall_aliases_edit.php', 'label' => gettext('Add a new alias')), ); include("head.inc"); @@ -186,37 +202,18 @@ function find_alias_reference($section, $field, $origname, &$is_alias_referenced - + + $alias){ - $show_alias = false; - switch ($selected_tab){ - case "all": - $show_alias= true; - break; - case "ip": - case "host": - case "network": - if (preg_match("/(host|network)/",$alias["type"])) - $show_alias= true; - break; - case "url": - if (preg_match("/(url)/i",$alias["type"])) - $show_alias= true; - break; - case "port": - if($alias["type"] == "port") - $show_alias= true; - break; - } - if ($show_alias ){ - ?> +?> + + + +
 
@@ -238,10 +235,13 @@ function find_alias_reference($section, $field, $origname, &$is_alias_referenced } ?> - + + + - + " class="btn btn-default btn-xs"> @@ -249,17 +249,14 @@ function find_alias_reference($section, $field, $origname, &$is_alias_referenced
+ +
-
- -
-
- - -
diff --git a/src/www/firewall_aliases_edit.php b/src/www/firewall_aliases_edit.php index ac10ba5a0b3..30c8bee0e88 100644 --- a/src/www/firewall_aliases_edit.php +++ b/src/www/firewall_aliases_edit.php @@ -230,15 +230,8 @@ } } - if($pconfig['type'] == 'host') { - header("Location: firewall_aliases.php?tab=ip"); - } elseif (strpos($pconfig['type'],'url') !== false) { - header("Location: firewall_aliases.php?tab=url"); - } else { - header("Location: firewall_aliases.php?tab=".$pconfig['type']); - } + header('Location: firewall_aliases.php'); exit; - } } } @@ -357,174 +350,168 @@ function toggleType() {
0) print_input_errors($input_errors); ?>
-
-
-

-
-
-
-
- - - - - - - - - - - - - - - - - - - + + + + + +
- - -
- - - - - - -
- - -
- - -
- - - - - - - - - - +
+ +
+ + + + + + + + + + + + + + + + + + + - - - - - -
+ + +
+ + + + + + +
+ + +
+ + +
+ + + + + + + + + + $aliasurl): + $detail_desc = explode("||", $pconfig['detail']); + foreach ($pconfig['aliasurl'] as $aliasid => $aliasurl): ?> - - - - - + + + + - + + $address): + else: + $detail_desc = explode("||", $pconfig['detail']); + if (empty($pconfig['address']) && isset($pconfig['url'])) { + $addresslst = array($pconfig['url']); + } else { + $addresslst = explode(' ', $pconfig['address']); + } + foreach ($addresslst as $addressid => $address): ?> - - - - - + + + + - + + - - - - - - -
-
-
- - - "> - +
+
+
+ + + "> + - + -
-
-
- - - "/> - +
+
+
+ + + "/> + - + -
-
-
-
  - " /> - " onclick="window.location.href=''" /> -
- - - +
+
+
+ + + +   + + " /> + " onclick="window.location.href=''" /> + + + +
diff --git a/src/www/firewall_aliases_import.php b/src/www/firewall_aliases_import.php index fe2649f8c65..ff6aff790e6 100644 --- a/src/www/firewall_aliases_import.php +++ b/src/www/firewall_aliases_import.php @@ -153,67 +153,63 @@
0) print_input_errors($input_errors); ?>
-
-
-

-
-
-
- - - - - - - - - - - - - - - - - - - - -
- - -
- - -
- - -
- - -
  - " /> - " - onclick="window.location.href=''" /> -
-
-
+
+
+ + + + + + + + + + + + + + + + + + + + + +
+ + +
+ + +
+ + +
+ + +
  + " /> + " + onclick="window.location.href=''" /> +
+