-
Notifications
You must be signed in to change notification settings - Fork 759
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
118 additions
and
121 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b315adThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Woi ready, set, go for round 3 :)
Changes:
3b315adThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As before: removed f14be5c, successfully applied this patch but kept the DynDNS patch. Going to reboot now, but don't expect feedback before tomorrow evening.
3b315adThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried this patch to see if dhclient exiting was fixed on renews, but I'm seeing the same behaviour, where the IP is obtained but then dhclient exits, leaving the interface unconfigured.
3b315adThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks even better then patch 1 and 2:
3b315adThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, I still not understand: Why does
rc.newwanipv6need to run every 15 minutes at all? Is this due to the ISPs DHCP renewal time?3b315adThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Woi ok, if apinger is not running it should not be probed there then... 89d73f6916f786
reload is forced by pppoe or at least the pppoe daemon, I don't know why. The two lines you see there now are basically two diagnostic prints. as you noted we don't do anything anymore here in those cases that would force a reload / disrupt connectivity.
@deviantintegral ok, so we need to look again at how dhclient is handled, not related to IP handling ;(
3b315adThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fichtner
apinger:
Should I test 89d73f6? I'm currently running 17.1.7.
Regarding the Reload: I still think it's kind of wired to have it every 15min. Since I couldn't find any information in the logs, I ticked
Enable debugin theAdvancedtab ofDHCPv6 client configuration, just to figure out it breaks IPv6 (no IPv6 addresses for my client any more). Should I open a new bug report for this?Update: To get IPv6 working again, disabling debug and a reboot wasn't sufficient. I had to disable and reconfigure IPv6 completely, followed by a reboot.
3b315adThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Woi the commit only removes the error you've reported previously. apinger does not run so it's not necessary to probe it. now it looks like apinger is actually started/configured, but exits right away because it can't find an IP to look for.
PPPoE/mpd5 is doing these disconnects and we just have to act on them or ignore them.... I have no idea why they are there and debugging this is out of scope.