config: don't use notices in early/low level code

opnsense · Nov 12, 2015 · 435e47e · 435e47e
1 parent 59b865c
commit 435e47e
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/etc/inc/config.lib.inc b/src/etc/inc/config.lib.inc
@@ -67,12 +67,11 @@ function parse_config()
 		$backups = $cnf->getBackups();
 		if (count($backups) > 0) {
 			// load last backup
-			syslog(LOG_ERR,	sprintf('parse_config(): %s', gettext('No (valid) config.xml found, attempting last known config restore.')));
-			file_notice("config.xml", gettext("No (valid) config.xml found, attempting last known config restore."), "OPNsenseConfigurator", "");
+			syslog(LOG_ERR,	gettext('No valid config.xml found, attempting last known config restore.'));
 			$cnf->restoreBackup($backups[0]);
 		} else {
 			// we don't have backups, try to load the default
-			syslog(LOG_ERR, sprintf('parse_config(): %s', gettext('No config.xml found, attempting to restore factory config.')));
+			syslog(LOG_ERR, gettext('No valid config.xml found, attempting to restore factory config.'));
 			$cnf->restoreBackup('/usr/local/etc/config.xml');
 		}
 	}
@@ -195,8 +194,7 @@ function write_config($desc = 'Unknown', $backup = true)
 		$cnf->save($revision_info, $backup);
 	} catch (OPNsense\Core\ConfigException $e) {
 		// write failure
-		log_error(gettext("WARNING: Config contents could not be saved. Could not open file!"));
-		file_notice('config.xml', sprintf("%s\n", gettext('Unable to open /conf/config.xml for writing in write_config()')));
+		syslog(LOG_ERR, gettext('WARNING: Config contents could not be saved. Could not open file!'));
 		return -1;
 	}