Proxy, minor regression in authentication. contraints are always chec…

…ked now, which should only apply for local. related to #3250

(cherry picked from commit 54551b0)
(cherry picked from commit e8dbda3)

src/opnsense/mvc/app/library/OPNsense/Auth/Services/Squid.php

@@ -89,6 +89,11 @@ public function getUserName()
     public function checkConstraints()
     {
          // XXX: replace with group membership in 19.7
-         return (new ACL())->hasPrivilege($this->getUserName(), 'user-proxy-auth');
+         if (in_array('Local Database', $this->supportedAuthenticators())) {
+            return (new ACL())->hasPrivilege($this->getUserName(), 'user-proxy-auth');
+        } else {
+            // XXX non local auth, constraints not used. remove with https://github.com/opnsense/core/issues/3250
+            return true;
+        }
     }
 }