From 611ee6a4a23f0a297d23efe544340f909e9c1199 Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Mon, 20 May 2024 17:17:35 +0200 Subject: [PATCH] mvc: model silence spurious validation message when explitly asked to ignore validations. (https://github.com/opnsense/core/issues/7470) --- src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php b/src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php index 9829f6b454..2908c1d6a4 100644 --- a/src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php +++ b/src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php @@ -641,8 +641,9 @@ public function serializeToConfig($validateFullModel = false, $disable_validatio $exception_msg_part .= sprintf("{%s}", $field_value); } $exception_msg .= "$exception_msg_part\n"; - // always log validation errors - $logger->error($exception_msg_part); + if (!$disable_validation) { + $logger->error($exception_msg_part); + } } if (!$disable_validation) { throw new ValidationException($exception_msg);