(legacy, firewall_virtual_ip_edit.php) apply issue on new vip

opnsense · Oct 11, 2015 · 8d28488 · 8d28488
1 parent 5b67fa4
commit 8d28488
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/www/firewall_virtual_ip_edit.php b/src/www/firewall_virtual_ip_edit.php
@@ -205,11 +205,11 @@ function find_last_used_vhid() {
             $toapplylist = array();
         }
         if (isset($id)) {
-            if (isset($toapplylist[$id])) {
-                $toapplylist[$id] = $a_vip[$id];
-            } else {
-                $toapplylist[] = $a_vip[$id];
-            }
+            // save existing content before changing it
+            $toapplylist[$id] = $a_vip[$id];
+        } else {
+            // new entry, no old data
+            $toapplylist[count($a_vip)] = array();
         }
 
         if (isset($id)) {