VPN: OpenVPN: Instances - properly map user groups for authentication…

… to align with legacy code. closes #6732
opnsense · Aug 10, 2023 · 8f51311 · 8f51311
1 parent aa81bbd
commit 8f51311
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.php b/src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.php
@@ -260,11 +260,16 @@ public function getInstanceById($server_id, $role = null)
                         }
                     }
                 }
+                // legacy uses group names, convert key (gid) to current name
+                $local_group = null;
+                if (!empty((string)$node->local_group)) {
+                    $local_group = $node->local_group->getNodeData()[(string)$node->local_group]['value'];
+                }
                 return [
                     'role' => (string)$node->role,
                     'vpnid' => $server_id,
                     'authmode' => (string)$node->authmode,
-                    'local_group' => (string)$node->local_group,
+                    'local_group' => $local_group,
                     'strictusercn' => (string)$node->strictusercn,
                     'dev_mode' => (string)$node->dev_type,
                     'topology_subnet' => $node->topology == 'subnet' ? '1' : '0',