From b52bf63e9e3ac8f14f5725086e0f9715b072c136 Mon Sep 17 00:00:00 2001 From: Franco Fichtner Date: Tue, 1 Aug 2023 08:03:36 +0200 Subject: [PATCH] firewall: groups were not correctly parsed for menu post-migration --- src/opnsense/mvc/app/models/OPNsense/Base/Menu/MenuSystem.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/opnsense/mvc/app/models/OPNsense/Base/Menu/MenuSystem.php b/src/opnsense/mvc/app/models/OPNsense/Base/Menu/MenuSystem.php index 9a7b243d14..f68a180e9c 100644 --- a/src/opnsense/mvc/app/models/OPNsense/Base/Menu/MenuSystem.php +++ b/src/opnsense/mvc/app/models/OPNsense/Base/Menu/MenuSystem.php @@ -209,7 +209,7 @@ public function __construct() /* we need both if and gr reference */ $iftargets['if'][(string)$node->ifname] = (string)$node->ifname; $iftargets['gr'][(string)$node->ifname] = (string)$node->ifname; - foreach (explode(' ', (string)$node->members) as $member) { + foreach (preg_split('/[ |,]+/', (string)$node->members) as $member) { if (!array_key_exists($member, $ifgroups)) { $ifgroups[$member] = []; }