interfaces: long group names vs. pf(4)

PR: https://forum.opnsense.org/index.php?topic=12527.0
opnsense · Apr 26, 2019 · d40c917 · d40c917
1 parent 6b8fc10
commit d40c917
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/www/interfaces_groups_edit.php b/src/www/interfaces_groups_edit.php
@@ -57,8 +57,13 @@
             }
         }
     }
-    if (preg_match("/([^a-zA-Z0-9_])+/", $pconfig['ifname'], $match) || empty($pconfig['ifname'])) {
-        $input_errors[] = gettext("Only letters A-Z are allowed as the group name.");
+
+    if (preg_match('/([^a-zA-Z0-9_])+/', $pconfig['ifname'], $match) || empty($pconfig['ifname'])) {
+        $input_errors[] = gettext('Only letters, digits and underscores are allowed as the group name.');
+    }
+
+    if (!empty($pconfig['ifname']) && strlen($pconfig['ifname']) > 15) {
+        $input_errors[] = gettext('The group name shall not be longer than 15 characters.');
     }
 
     foreach (get_configured_interface_with_descr() as $gif => $gdescr) {