Skip to content
Permalink
Browse files

firewall: repair logic for ICMP fixup required by pfctl after refactor

  • Loading branch information...
fichtner committed Jan 29, 2018
1 parent 612a96e commit f26883d4b5164ad002f27d3f13066d7282bf0650
Showing with 3 additions and 3 deletions.
  1. +3 −3 src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php
@@ -222,14 +222,14 @@ private function parseFilterRules()
}
// icmp-type switch (ipv4/ipv6)
if ($rule['protocol'] == "icmp" && !empty($rule['icmptype'])) {
if ($ipproto == 'inet') {
if ($rule['ipprotocol'] == 'inet') {
$rule['icmp-type'] = $rule['icmptype'];
} elseif ($ipproto == 'inet6') {
} elseif ($rule['ipprotocol']== 'inet6') {
$rule['icmp6-type'] = $rule['icmptype'];
}
}
// icmpv6
if ($ipproto == 'inet6' && !empty($rule['protocol']) && $rule['protocol'] == "icmp") {
if ($rule['ipprotocol'] == 'inet6' && !empty($rule['protocol']) && $rule['protocol'] == "icmp") {
$rule['protocol'] = 'ipv6-icmp';
}
// set prio

0 comments on commit f26883d

Please sign in to comment.
You can’t perform that action at this time.