From ff1991cdee25d86181276143f0b9abfb90963d68 Mon Sep 17 00:00:00 2001
From: Ad Schellevis <ad@opnsense.org>
Date: Thu, 21 Mar 2024 14:09:12 +0100
Subject: [PATCH] Interfaces - change help text to reflect reality. closes
 https://github.com/opnsense/core/issues/7339

For dhcp type interfaces, gateways are being pushed by the server and we automatically assume these are "external". For static ones you can configure similar behavior, but only explicit. When selecting a gateway, both reply-to and source nat rules are affected.
When nothing is chosen (now default, earlier "auto-detect"), normal routing rules apply and nothing special happens.
---
 src/www/interfaces.php | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/www/interfaces.php b/src/www/interfaces.php
index 897770bc56e..9a408490b38 100644
--- a/src/www/interfaces.php
+++ b/src/www/interfaces.php
@@ -2060,7 +2060,7 @@ function toggle_wirelesscfg() {
                           <td><a id="help_for_gateway" href="#" class="showhelp"><i class="fa fa-info-circle"></i></a> <?= gettext('IPv4 Upstream Gateway') ?></td>
                           <td>
                             <select name="gateway" class="selectpicker" data-style="btn-default" data-size="10" id="gateway">
-                              <option value="none"><?= gettext('Auto-detect') ?></option>
+                              <option value="none"><?= gettext('Default') ?></option>
 <?php
                               foreach ((new \OPNsense\Routing\Gateways())->gatewayIterator() as $gateway):
                                 if ($gateway['interface'] == $if && is_ipaddrv4($gateway['gateway'])):
@@ -2074,8 +2074,8 @@ function toggle_wirelesscfg() {
 ?>
                             </select>
                             <div class="hidden" data-for="help_for_gateway">
-                              <?= gettext('If this interface is a multi-WAN interface, select an existing gateway from the list. For single WAN interfaces a gateway must be ' .
-                                          'created but set to auto-detect. For a LAN a gateway is not necessary to be set up.') ?>
+                              <?= gettext('Select a gateway from the list to reply the incoming packets to the proper next hop on their way back and apply source NAT when configured. ' .
+                                          'Usually LAN type connections leave this to default.');?>
                             </div>
                           </td>
                         </tr>
@@ -2575,7 +2575,7 @@ function toggle_wirelesscfg() {
                           <td><a id="help_for_gatewayv6" href="#" class="showhelp"><i class="fa fa-info-circle"></i></a> <?=gettext("IPv6 Upstream Gateway"); ?></td>
                           <td>
                             <select name="gatewayv6" class="selectpicker" data-size="10" data-style="btn-default" id="gatewayv6">
-                              <option value="none"><?= gettext('Auto-detect') ?></option>
+                              <option value="none"><?= gettext('Default') ?></option>
 <?php
                               foreach ((new \OPNsense\Routing\Gateways())->gatewayIterator() as $gateway):
                                 if ($gateway['interface'] == $if && is_ipaddrv6($gateway['gateway'])):
@@ -2589,8 +2589,8 @@ function toggle_wirelesscfg() {
 ?>
                             </select>
                             <div class="hidden" data-for="help_for_gatewayv6">
-                              <?= gettext('If this interface is a multi-WAN interface, select an existing gateway from the list. For single WAN interfaces a gateway must be ' .
-                                          'created but set to auto-detect. For a LAN a gateway is not necessary to be set up.') ?>
+                              <?= gettext('Select a gateway from the list to reply the incoming packets to the proper next hop on their way back. ' .
+                                          'Usually LAN type connections leave this to default.');?>
                             </div>
                           </td>
                         </tr>