Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI "Firewall: Aliases" fail to add host alias with underscore in Alias #1113

Closed
nemesix29 opened this issue Aug 4, 2016 · 3 comments
Closed

GUI "Firewall: Aliases" fail to add host alias with underscore in Alias #1113

nemesix29 opened this issue Aug 4, 2016 · 3 comments

Comments

@nemesix29
Copy link

nemesix29 commented Aug 4, 2016 •
edited
Loading

Can't add Alias within alias with underscore in name of them.

It's work fine without underscore

2016-08-04 19_51_50-view _ aliases _ firewall _ nh-fw01 nexxx us
@fichtner
Copy link
Member

fichtner commented Aug 4, 2016

Hi there,

Underscores are forbidden in the host name specification:

https://en.wikipedia.org/wiki/Hostname#Restrictions_on_valid_host_names

Or is there something I'm not seeing?

Cheers,
Franco

@AdSchellevis
Copy link
Member

@fichtner alias nesting should work, is_domain() is valid for most alias names :)

@fichtner
Copy link
Member

fichtner commented Aug 4, 2016

ah ok sorry, nice catch!

pv2b pushed a commit to pv2b/core that referenced this issue Aug 7, 2016
@AdSchellevis @pv2b
(firewall, alias) bug in alias nesting, closes opnsense#1113
9d8ed66
pv2b pushed a commit to pv2b/core that referenced this issue Aug 7, 2016
@AdSchellevis @pv2b
(firewall, alias) bug in alias nesting, closes opnsense#1113
98e9b15
fichtner pushed a commit that referenced this issue Aug 29, 2016
@AdSchellevis @fichtner
(firewall, alias) bug in alias nesting, closes #1113
9b74e3c 
(cherry picked from commit 90a6bb7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fichtner @AdSchellevis @nemesix29