Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change password page in lobby should show QR code if available #1197

Closed
fichtner opened this issue Sep 21, 2016 · 5 comments
Closed

change password page in lobby should show QR code if available #1197

fichtner opened this issue Sep 21, 2016 · 5 comments
Labels
feature Adding new functionality help wanted Contributor missing / timeout

Comments

@fichtner
Copy link
Member

To distribute the QR code to users, it's not practical to hand the code to a normal user.

@AdSchellevis does this make sense?

via: https://forum.opnsense.org/index.php?topic=3638.0

@fichtner fichtner added the feature Adding new functionality label Sep 21, 2016
@fichtner fichtner added this to the 17.1 milestone Sep 21, 2016
@fichtner fichtner self-assigned this Sep 21, 2016
@AdSchellevis
Copy link
Member

@fichtner normally the token codes should be secret and only delivered one time to the user (also the reason why you can't read the secret back from the google app). Providing the user his secret using only username+password is generally not a very good idea.
I certainly don't want to make this a default, its not very safe.

@fichtner
Copy link
Member Author

@AdSchellevis ok, but that generally puts OPNsense in a position where it can't do that. Maybe a (default off) authentication server settings should control this behaviour?

@AdSchellevis
Copy link
Member

@fichtner then its probably more something for the "general settings", I don't mind if its off by default (although it should come with a warning). Normally tokens are kept at a very safe location, to put all in the same box we don't have that choice, but exposing the secret to the user is really not the intended method.

@nick-laird
Copy link

Maybe make it appear only on first view so the user can obtain it over a SSL connection but only once? If the admin changes it, it could reappear for the user one time again? (if the user doesn't see it, it was possibly snagged by someone else and therefore should be invalidated anyway.)

@fichtner fichtner modified the milestones: 17.7, 17.1 Jan 23, 2017
@fichtner fichtner modified the milestones: Future, 17.7 Jul 21, 2017
@fichtner fichtner added the help wanted Contributor missing / timeout label Jul 21, 2017
@fichtner fichtner removed their assignment Jul 21, 2017
@AdSchellevis
Copy link
Member

timeout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding new functionality help wanted Contributor missing / timeout
Development

No branches or pull requests

3 participants