Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firewall: logging for NAT rules #1494

Closed
cryptochrome opened this issue Mar 21, 2017 · 14 comments
Closed

firewall: logging for NAT rules #1494

cryptochrome opened this issue Mar 21, 2017 · 14 comments
Assignees
Labels
feature Adding new functionality
Milestone

Comments

@cryptochrome
Copy link

Currently, when you add a new port forwarding rule and let it automatically create a corresponding firewall rule, that firewall rule has logging disabled and the rule can't be edited. So if I want logging, I would have to add the firewall rule manually and disable automatic rule creation.

Why not give us an option to enable logging on these auto-created rules?

@AdSchellevis
Copy link
Member

There's a good reason why automatic rules can't be edited, the automatic generated rules lack validations which causes more issues if we let users edit them, for reference see #858 and the associated forum posts.

@cryptochrome
Copy link
Author

cryptochrome commented Mar 21, 2017

I didn't necessarily imply that the auto-generated rules should be changeable. You could just add an additional option to the Port Forwarder setup page next to the field that asks if and which firewall should be created. Just add a checkbox, "enable logging".

@fichtner
Copy link
Member

I'm taking this as discussed in the forum :)

@fichtner fichtner self-assigned this Mar 21, 2017
@fichtner fichtner added the feature Adding new functionality label Mar 21, 2017
@fichtner fichtner added this to the 17.7 milestone Mar 21, 2017
@AdSchellevis
Copy link
Member

@fichtner no problem, just referencing the cause here and not entirely sure it's a good idea to extend the forwarder page with more firewall settings.

@fichtner
Copy link
Member

I agree, it will go to system: settings: logging

@AdSchellevis
Copy link
Member

@fichtner thanks!

@cryptochrome
Copy link
Author

thanks guys :) 👍

@fichtner fichtner modified the milestones: 18.1, 17.7 Jul 21, 2017
@fichtner fichtner modified the milestones: 18.1, 18.7 Jan 17, 2018
@fichtner
Copy link
Member

Also for port forward, via https://forum.opnsense.org/index.php?topic=7266.0

@fichtner fichtner removed this from the 18.7 milestone Feb 27, 2018
@fichtner fichtner added this to the 19.1 milestone Jul 15, 2018
@fichtner fichtner changed the title [REQ] - Logging for automatic rules (NAT) firewall: logging for NAT rules Sep 12, 2018
@ccesario
Copy link

ccesario commented Nov 9, 2018

Hi Folks, is there any ETA for this feature!?

Regards
Carlos

@drinn
Copy link

drinn commented Nov 10, 2018

I'd like very much for this feature as well. It looks like it's been pushed back for several releases now. Hopefully they will still be able to add this into 19.1.

@fichtner
Copy link
Member

Like this? :) Although it's not what @AdSchellevis wanted as you can enable it per port forward rule ;)

screenshot 2018-11-11 at 8 48 15 am

@drinn
Copy link

drinn commented Nov 11, 2018

Thank you, @fichtner for your work on this! I'm assuming I'd need to change my release type to "development" if I want to see these changes reflected on my running opnsense instance (assuming I want to try it out before the next release)?

@ccesario
Copy link

Hey @fichtner , only to configr .... is this in 18.7.8 ?
I'm not able to see log option in Firewall: NAT: Port Forward rule.

Carlos

@fichtner
Copy link
Member

it's on the development version now (18.7.8 -> Release type Development, Check for updates again) . there is one issue left with the feature: the live log shows the wrong rule label. needs @AdSchellevis's help but not super urgent. I'm hoping it's done in 18.7.9 or 18.7.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding new functionality
Development

No branches or pull requests

5 participants