Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web proxy: yoyo ACL https download writes garbage to disk #1510

Closed
fichtner opened this issue Mar 29, 2017 · 6 comments
Closed

web proxy: yoyo ACL https download writes garbage to disk #1510

fichtner opened this issue Mar 29, 2017 · 6 comments
Assignees
Labels
bug Production bug
Milestone

Comments

@fichtner
Copy link
Member

Hi Ad, do you know what's wrong? I could only verify for now :(

https://forum.opnsense.org/index.php?topic=4893.0

@fichtner fichtner added the bug Production bug label Mar 29, 2017
@fichtner fichtner added this to the 17.7 milestone Mar 29, 2017
@AdSchellevis
Copy link
Member

Oo it's gzipped... which won't get unpacked by request.raw
image

As soon as I have some time I'll try to prepare a fix.

@fichtner
Copy link
Member Author

doesn't http take care of this? if this already happens then what happens with chunked encoding??

@fabianfrz
Copy link
Member

just use zlib for that. Python has a module for that:
https://docs.python.org/2/library/zlib.html

@AdSchellevis
Copy link
Member

i know, it's just a time constraint.

@AdSchellevis
Copy link
Member

please be aware that the list mentioned in the forum (https://pgl.yoyo.org/as/serverlist.php?hostformat=squid-dstdom-regex&showintro=0&mimetype=plaintext) isn't compatible with our system, because it's a regexp and not a domain list (https://pgl.yoyo.org/as/serverlist.php?hostformat=plain&showintro=0&mimetype=plaintext)

@fichtner
Copy link
Member Author

thanks for fixing 👍 I'll coordinate with the user

fichtner pushed a commit that referenced this issue Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Production bug
Development

No branches or pull requests

3 participants