Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.1.5] Label incorrect when importing a CA #1581

Closed
sjorge opened this issue Apr 30, 2017 · 3 comments
Closed

[17.1.5] Label incorrect when importing a CA #1581

sjorge opened this issue Apr 30, 2017 · 3 comments
Assignees
@fichtner
Labels
bug Production bug
Milestone
17.7

Comments

@sjorge
Copy link
Contributor

sjorge commented Apr 30, 2017

Serial for next certificate

This value actually gets incremented by 1 it seems.
So if you enter 42... the next certificate is not 42 but 43.
@fichtner
Copy link
Member

fichtner commented May 1, 2017

We run the risk of issuing the same serial twice if we fix the code, should be limit the serial to > 0 and then do -1 before store?

@fichtner fichtner self-assigned this May 1, 2017
@fichtner fichtner added the bug Production bug label May 1, 2017
@fichtner fichtner added this to the 17.7 milestone May 1, 2017
@sjorge
Copy link
Contributor Author

sjorge commented May 1, 2017

Or change the label to 'Serial of last certificate' ?

@fichtner
Copy link
Member

fichtner commented May 1, 2017

changing labels means updating manuals and translations :)

fichtner added a commit that referenced this issue May 2, 2017
@fichtner
system: value is ptional so only validate if there #1581
2d42d84
fichtner added a commit that referenced this issue May 2, 2017
@fichtner
system: fix off by one and add validation; closes #1581
783abeb 
(cherry picked from commit 6d44375)
(cherry picked from commit 2d42d84)
fichtner added a commit that referenced this issue Jan 5, 2018
@fichtner
system: play whac-a-mole with the serial number #1581
945b866
fichtner added a commit that referenced this issue Jan 5, 2018
@fichtner
system: play whac-a-mole with the serial number #1581
67a0c74 
(cherry picked from commit 945b866)
fichtner added a commit that referenced this issue Jan 5, 2018
@fichtner
system: play whac-a-mole with the serial number #1581
c1945a8 
(cherry picked from commit 945b866)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fichtner fichtner

Labels
bug Production bug
Milestone
17.7
Development

No branches or pull requests
2 participants
@sjorge @fichtner