Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captive Portal: Radius Accounting improvements #162

Closed
AdSchellevis opened this issue May 4, 2015 · 4 comments
Closed

Captive Portal: Radius Accounting improvements #162

AdSchellevis opened this issue May 4, 2015 · 4 comments
Assignees
Labels
feature Adding new functionality help wanted Contributor missing / timeout
Milestone

Comments

@AdSchellevis
Copy link
Member

Current support is probably broken and code base is still quite messy.
Needs rewrite using a cleaner and better understandable code.

@miken32
Copy link

miken32 commented May 27, 2015

FYI getVolume was perfectly functional (we're using it now in pfSense) but I do support a rewrite of captive portal entirely. It's quite the mess. Likely you were running into this bug: https://redmine.pfsense.org/issues/4131

We are planning to expand our use of custom-built routers (currently most of our hospitality sites use HP or Nomadix, with 10-15 pfSense) and are looking at giving opnSense 15.7 a try. Captive portal/RADIUS is a big part of our networks, so I'll be keeping an eye on this for sure!

@AdSchellevis
Copy link
Member Author

Thanks for the tip.

We had to rewrite a lot of the captive portal code to get rid of all the non standard kernel hooks, unfortunately we had to drop some functionality in the first release (like limiting traffic). At the moment we're working on the traffic shaper component which also has a relation to the captive portal part due to the technology it's using (ipfw/dummynet).
Eventually we want to bring captive portal back to a more functional state, by also rewriting this part using our new framework.

I hope you like OPNsense, although you might miss some features in captive portal due to our cleanups.

@fichtner fichtner added feature Adding new functionality help wanted Contributor missing / timeout labels Jun 24, 2015
@fichtner fichtner added this to the 16.1 milestone Jun 24, 2015
@fichtner fichtner self-assigned this Jun 24, 2015
@fichtner
Copy link
Member

We've been discussing this recently and it seems that authentication is working fine in general:

https://forum.opnsense.org/index.php?topic=686.0

We focus on getting authentication into shape, then take a look at accounting which may or may not have some issues. One step at a time. :)

@fichtner fichtner changed the title Reimplement captive portal Radius support Captive portal Radius Authentication/Accounting improvements Jun 24, 2015
@fichtner fichtner changed the title Captive portal Radius Authentication/Accounting improvements Captive Portal: Radius Authentication/Accounting improvements Jun 24, 2015
@fichtner fichtner changed the title Captive Portal: Radius Authentication/Accounting improvements Captive Portal: Radius Accounting improvements Jun 26, 2015
@fichtner
Copy link
Member

Radius is being rewritten for the new captive portal, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding new functionality help wanted Contributor missing / timeout
Development

No branches or pull requests

3 participants