Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

users: unhide QR code by default or add a hint? #1639

Closed
fichtner opened this issue May 12, 2017 · 4 comments
Closed

users: unhide QR code by default or add a hint? #1639

fichtner opened this issue May 12, 2017 · 4 comments
Assignees
@AdSchellevis
Labels
cleanup Low impact changes
Milestone
17.7

Comments

@fichtner
Copy link
Member

Hi Ad,

Quick questions since users seem to miss that they have easy access to QR codes for 2FA:

Should we unhide it or at least add a visible note? I'm partially for unhiding it, but I can understand if there are concerns with the secrecy of it and that it could be captured by photo/film in an instant.

Also see: https://forum.opnsense.org/index.php?topic=5155.0

Thanks,
Franco
@fichtner fichtner added cleanup Low impact changes support Community support labels May 12, 2017
@fichtner fichtner added this to the 17.7 milestone May 12, 2017
@AdSchellevis
Copy link
Member

let's add a visible note then, maybe as simple as chaning the caption in :
OTP seed (click to unhide)

@fichtner fichtner removed the support Community support label May 12, 2017
@fichtner
Copy link
Member Author

Sounds good, do you want to do it or should I?

@fichtner
Copy link
Member Author

Thanks! :)

@AdSchellevis
Copy link
Member

you're welcome

fichtner added a commit that referenced this issue May 12, 2017
@fichtner
system: while the former is good, users probably want "more" #1639
1c037c4 
Add a clickable unhide button in an extra table row for the QR code
when it is available only.  Makes the help text the help text only.
fichtner pushed a commit that referenced this issue May 12, 2017
@AdSchellevis @fichtner
OTP, add note, closes #1639
2e18cb7 
(cherry picked from commit c7d8d10)
(cherry picked from commit 1c037c4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdSchellevis AdSchellevis

Labels
cleanup Low impact changes
Milestone
17.7
Development

No branches or pull requests
2 participants
@fichtner @AdSchellevis